Closed Bug 615571 Opened 14 years ago Closed 14 years ago

pymake doesn't display build errors anymore

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking2.0 -)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
blocking2.0 --- -

People

(Reporter: sdwilsh, Unassigned)

References

Details

When I have a compile error, pymake doesn't print them out anymore, and I have to manually run the command myself:

c:\Code\places\config\rules.mk:1479:0$ cl InvokeClWithDependencyGeneration cl -FonsNavHistory.obj -c -D_HAS_EXCEPTIONS=0 -I../../../../dist/stl_wrappers  -DSQLITE_DEFAULT_PAGE_SIZE=32768 -DXPCOM_TRANSLATE_NSGM_ENTRY_POINT=1 -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES  -DOSTYPE=\"WINNT6.1\" -DOSARCH=WINNT -DEXCLUDE_SKIA_DEPENDENCIES -DCHROMIUM_MOZILLA_BUILD  -DUNICODE -D_UNICODE -DNOMINMAX -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -D_SECURE_ATL -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DCOMPILER_MSVC -DOS_WIN=1 -DWIN32 -D_WIN32 -D_WINDOWS -DWIN32_LEAN_AND_MEAN  -I../../../../../toolkit/components/places/src/../../build -I../../../../../ipc/chromium/src -I../../../../../ipc/glue -I../../../../ipc/ipdl/_ipdlheaders  -I../../../../../toolkit/components/places/src -I. -I../../../../dist/include -I../../../../dist/include/nsprpub  -Ic:/Code/places/obj-x86/dist/include/nspr -Ic:/Code/places/obj-x86/dist/include/nss   -GR- -TP -nologo -Zc:wchar_t- -W3 -Gy -Fdgenerated.pdb -wd4800  -DDEBUG -D_DEBUG -DTRACING -Zi -MDd           -FI ../../../../dist/include/mozilla-config.h -DMOZILLA_CLIENT c:/Code/places/obj-x86/toolkit/components/places/src/../../../../../toolkit/components/places/src/nsNavHistory.cpp
c:\Code\places\config\rules.mk:1479:0: command 'cl InvokeClWithDependencyGeneration cl -FonsNavHistory.obj -c -D_HAS_EXCEPTIONS=0 -I../../../../dist/stl_wrappers  -DSQLITE_DEFAULT_PAGE_SIZE=32768 -DXPCOM_TRANSLATE_NSGM_ENTRY_POINT=1 -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES  -DOSTYPE=\"WINNT6.1\" -DOSARCH=WINNT -DEXCLUDE_SKIA_DEPENDENCIES -DCHROMIUM_MOZILLA_BUILD  -DUNICODE -D_UNICODE -DNOMINMAX -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -D_SECURE_ATL -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DCOMPILER_MSVC -DOS_WIN=1 -DWIN32 -D_WIN32 -D_WINDOWS -DWIN32_LEAN_AND_MEAN  -I../../../../../toolkit/components/places/src/../../build -I../../../../../ipc/chromium/src -I../../../../../ipc/glue -I../../../../ipc/ipdl/_ipdlheaders  -I../../../../../toolkit/components/places/src -I. -I../../../../dist/include -I../../../../dist/include/nsprpub  -Ic:/Code/places/obj-x86/dist/include/nspr -Ic:/Code/places/obj-x86/dist/include/nss         -GR- -TP -nologo -Zc:wchar_t- -W3 -Gy -Fdgenerated.pdb -wd4800  -DDEBUG -D_DEBUG -DTRACING -Zi -MDd           -FI ../../../../dist/include/mozilla-config.h -DMOZILLA_CLIENT c:/Code/places/obj-x86/toolkit/components/places/src/../../../../../toolkit/components/places/src/nsNavHistory.cpp' failed, return code -127
c:\Code\places\config\rules.mk:952:0: command 'c:/mozilla-build/python/python.exe c:/Code/places/build/pymake/pymake/../make.py -C src libs' failed, return code 2
c:\Code\places\config\rules.mk:751:0: command 'c:/mozilla-build/python/python.exe c:/Code/places/build/pymake/pymake/../make.py libs' failed, return code 2
341 obj-x86 $ cd toolkit/components/places/src/
342 src $ cl InvokeClWithDependencyGeneration cl -FonsNavHistory.obj -c -D_HAS_
EXCEPTIONS=0 -I../../../../dist/stl_wrappers  -DSQLITE_DEFAULT_PAGE_SIZE=32768
-DXPCOM_TRANSLATE_NSGM_ENTRY_POINT=1 -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEX
PORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -
DIMPL_NS_NET -DIMPL_THEBES  -DOSTYPE=\"WINNT6.1\" -DOSARCH=WINNT -DEXCLUDE_SKIA
_DEPENDENCIES -DCHROMIUM_MOZILLA_BUILD  -DUNICODE -D_UNICODE -DNOMINMAX -D_CRT_
RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -D_SECURE_ATL -DCHROMIUM_BUILD -DU_ST
ATIC_IMPLEMENTATION -DCOMPILER_MSVC -DOS_WIN=1 -DWIN32 -D_WIN32 -D_WINDOWS -DWI
N32_LEAN_AND_MEAN  -I../../../../../toolkit/components/places/src/../../build -
I../../../../../ipc/chromium/src -I../../../../../ipc/glue -I../../../../ipc/ip
dl/_ipdlheaders  -I../../../../../toolkit/components/places/src -I. -I../../../
../dist/include -I../../../../dist/include/nsprpub  -Ic:/Code/places/obj-x86/di
st/include/nspr -Ic:/Code/places/obj-x86/dist/include/nss         -GR- -TP -nol
ogo -Zc:wchar_t- -W3 -Gy -Fdgenerated.pdb -wd4800  -DDEBUG -D_DEBUG -DTRACING -
Zi -MDd           -FI ../../../../dist/include/mozilla-config.h -DMOZILLA_CLIEN
T c:/Code/places/obj-x86/toolkit/components/places/src/../../../../../toolkit/c
omponents/places/src/nsNavHistory.cpp
InvokeClWithDependencyGeneration
c1xx : fatal error C1083: Cannot open source file: 'InvokeClWithDependencyGeneration': No such file or directory
cl
c1xx : fatal error C1083: Cannot open source file: 'cl': No such file or directory
nsNavHistory.cpp
c:\code\places\toolkit\components\places\src\nsNavHistory.h(912) : warning C4996: 'nsIBrowserHistory::RegisterOpenPage': was declared deprecated
        c:\Code\places\obj-x86\dist\include\nsIBrowserHistory.h(169) : see declaration of 'nsIBrowserHistory::RegisterOpenPage'
c:\code\places\toolkit\components\places\src\nsNavHistory.h(912) : warning C4996: 'nsIBrowserHistory::UnregisterOpenPage': was declared deprecated
        c:\Code\places\obj-x86\dist\include\nsIBrowserHistory.h(185) : see declaration of 'nsIBrowserHistory::UnregisterOpenPage'
c:\code\places\toolkit\components\places\src\nsNavBookmarks.h(490) : warning C4996: 'nsINavBookmarksService::GetItemGUID': was declared deprecated
        c:\Code\places\obj-x86\dist\include\nsINavBookmarksService.h(493) : see
declaration of 'nsINavBookmarksService::GetItemGUID'
c:\code\places\toolkit\components\places\src\nsNavBookmarks.h(490) : warning C4996: 'nsINavBookmarksService::SetItemGUID': was declared deprecated
        c:\Code\places\obj-x86\dist\include\nsINavBookmarksService.h(505) : see
declaration of 'nsINavBookmarksService::SetItemGUID'
c:\code\places\toolkit\components\places\src\nsNavBookmarks.h(490) : warning C4996: 'nsINavBookmarksService::GetItemIdForGUID': was declared deprecated
        c:\Code\places\obj-x86\dist\include\nsINavBookmarksService.h(514) : see
declaration of 'nsINavBookmarksService::GetItemIdForGUID'
c:/Code/places/obj-x86/toolkit/components/places/src/../../../../../toolkit/components/places/src/nsNavHistory.cpp(1852) : error C2065: 'CREATE_IDX_MOZ_BOOKMARKS_GUID' : undeclared identifier
Generating Code...
I know pymake isn't actually supported, but everyone I know who works on the project full time who developers on windows only uses it because make takes too long to build.  I spent a good hour or two yesterday trying to figure out why I kept getting this error, and I bet others are going to hit it too.
blocking2.0: --- → ?
This is some sort of native command issue, can you take a look Mitch?
I bet we're not echoing the console output of native commands ...
Likely fallout from bug 585011, yeah.

So, we shouldn't have to echo their output, they should be allowed to just print to stdout/stderr as usual. However, since we're running them in other processes, it's possible stdout/stderr isn't hooked up properly or something weird like that. My thought was just to ditch the process pool entirely and use the threadpool for everything and see how that worked.
Blocks: 585011
blocking2.0: ? → -
We should just back out cl as a native command until we can fix this.  I won't be able to touch it for some time, and I doubt ted has time either.  Not sure if Mitch can find time to fix this.
http://hg.mozilla.org/mozilla-central/rev/ae74a11a7d98
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.