Closed
Bug 615573
Opened 15 years ago
Closed 15 years ago
widget's MouseOver and MouseOut events have incorrect case
Categories
(Add-on SDK Graveyard :: General, defect)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
1.0b1
People
(Reporter: konstantin.novichikhin, Assigned: adw)
References
Details
Attachments
(1 file, 1 obsolete file)
|
3.45 KB,
patch
|
myk
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.12) Gecko/20101026 Firefox/3.6.12
Build Identifier: 0.9
The ones that actually work are onMouseOver and onMouseOut.
Reproducible: Always
Steps to Reproduce:
2 widgets with onMouseover and onMouseOver events.
Actual Results:
onMouseover does not work, onMouseOver works. Same for onMouseout.
Expected Results:
Either documentation or implementation is wrong.
|
Assignee | |
Comment 1•15 years ago
|
||
Thanks Konstantin!
Assignee: nobody → adw
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
OS: Windows XP → All
Hardware: x86 → All
|
||
Comment 3•15 years ago
|
||
Comment on attachment 494023 [details] [diff] [review]
patch
Nice catch!
However, these should actually be lowercase in the implementation (i.e. "onMouseover" for the "mouseover" event), for consistency with the DOM standard event type names (even though for non-DOM events with compound type names we should indeed use CamelCaps).
Attachment #494023 -
Flags: review?(myk) → review-
|
|
Assignee | |
Updated•15 years ago
|
Summary: onMouseover and onMouseout events in widget documentation have incorrect case → widget's MouseOver and MouseOut events have incorrect case
|
|
Assignee | |
Comment 4•15 years ago
|
||
Attachment #494023 -
Attachment is obsolete: true
Attachment #494150 -
Flags: review?(myk)
|
|
Assignee | |
Updated•15 years ago
|
Component: Documentation → General
QA Contact: documentation → general
|
|
||
Comment 5•15 years ago
|
||
Comment on attachment 494150 [details] [diff] [review]
patch 2
Roxors!
Attachment #494150 -
Flags: review?(myk) → review+
|
|
Assignee | |
Comment 6•15 years ago
|
||
Myk mentioned this should block the 0.10 release bug, so marking that dependency.
https://github.com/mozilla/addon-sdk/commit/40576187977090ae0b8ae1c0c2bdc04ce5902b06
https://github.com/mozilla/addon-sdk/commit/4d4cd73c2e6f2a7671c1233a21e71f40e77122c9
Blocks: 611250
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: -- → 0.10
|
|
||
Updated•14 years ago
|
Target Milestone: 0.10 → 1.0b1
You need to log in
before you can comment on or make changes to this bug.
Description
•