Closed Bug 615604 Opened 9 years ago Closed 9 years ago

Followups to pref sync cleanup

Categories

(Firefox :: Sync, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: philikon, Assigned: philikon)

References

Details

(Whiteboard: [qa-])

Attachments

(2 files)

The prefs engine uses nsIXULAppInfo.ID for the GUID, but we might want to require all GUIDs to be base64url in the future, so we could just base64url-encode that ID. That puts a cap of 48 characters on custom IDs (the ones that are not UUID-based) because GUIDs can only be up to 64 characters long.
Blocks: 615021
Assignee: nobody → philipp
Attachment #494042 - Flags: review?(mconnor)
Another follow up to bug 560580: Only accept pref updates for the current app, silently ignore prefs for other apps.
Attachment #494060 - Flags: review?(mconnor)
Attachment #494042 - Attachment description: v1 → Make pref GUIDs base64url
Summary: Make pref GUIDs base64url → Followups to pref sync cleanup
Comment on attachment 494042 [details] [diff] [review]
Make pref GUIDs base64url

Maybe we should add a getter here, rather than copying the same fragment all over the place?  this._prefRecordID or something?  Not picky.
Attachment #494042 - Flags: review?(mconnor) → review+
Attachment #494060 - Flags: review?(mconnor) → review+
(In reply to comment #3)
> Maybe we should add a getter here, rather than copying the same fragment all
> over the place?  this._prefRecordID or something?  Not picky.

Thanks to our brilliant separation of engine/tracker/store, we'd need it all over the place. I'll make it a module-level const.
Whiteboard: [qa-]
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.