615604 - Followups to pref sync cleanup

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Philipp von Weitershausen [:philikon]]

The prefs engine uses nsIXULAppInfo.ID for the GUID, but we might want to require all GUIDs to be base64url in the future, so we could just base64url-encode that ID. That puts a cap of 48 characters on custom IDs (the ones that are not UUID-based) because GUIDs can only be up to 64 characters long.

Comment 1

[Philipp von Weitershausen [:philikon]]

Attachment: Make pref GUIDs base64url

Comment 2

[Philipp von Weitershausen [:philikon]]

Attachment: Only accept pref updates for the current app

Another follow up to bug 560580: Only accept pref updates for the current app, silently ignore prefs for other apps.

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 494042 [details] [diff] [review]
Make pref GUIDs base64url

Maybe we should add a getter here, rather than copying the same fragment all over the place?  this._prefRecordID or something?  Not picky.

Comment 4

[Philipp von Weitershausen [:philikon]]

(In reply to comment #3)
> Maybe we should add a getter here, rather than copying the same fragment all
> over the place?  this._prefRecordID or something?  Not picky.

Thanks to our brilliant separation of engine/tracker/store, we'd need it all over the place. I'll make it a module-level const.

Comment 5

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/services/fx-sync/rev/913a409d4d89
https://hg.mozilla.org/services/fx-sync/rev/2c86b625bb89