615636 - Labels badly aligned when editing versions and milestones in admin pages

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Frédéric Buclin]

Due to bug 77193 and the addition of "Enable for Bugs", field labels are now badly aligned when editing versions and milestones in admin pages. Some are missing a align="right" to make them look correct (or a class, if we have one which does that). Only affects Bugzilla 4.1.

Comment 1

[Matt Selsky [:selsky]]

Attachment: Fix field labels v1

I used the "field_label" class and removed the hard-coded align/valign attributes.

I also added missing label tags to the component editing page.  Note that without this patch, the "Enabled For Bugs:" and "Bugs:" labels on the edit components page are left-aligned and non-bold.

Comment 2

[Frédéric Buclin]

Comment on attachment 556454 [details] [diff] [review]
Fix field labels v1

>=== modified file 'template/en/default/admin/components/edit-common.html.tmpl'

>+  <th class="field_label"><label for="component">Component:</label></th>
>   <td><input size="64" maxlength="64" name="component"
>              value="[%- comp.name FILTER html %]"></td>

The "for" attribute of <label> elements must point to an existing id. As the <input> field has no id="component" attribute, this won't work. You have to add the id attribute too when missing.



>=== modified file 'template/en/default/admin/components/edit.html.tmpl'

>+      <th class="field_label"><label for="isactive">Enabled For [% terms.Bugs %]:</label></td>

Mix of <th> </td>!


>+      <th class="field_label">[% terms.Bugs %]:</td>

Same here.

Comment 3

[Matt Selsky [:selsky]]

Attachment: Fix field labels v2

Comment 4

[Frédéric Buclin]

Comment on attachment 556527 [details] [diff] [review]
Fix field labels v2

This is great, thanks! r=LpSolit

Comment 5

[Frédéric Buclin]

I fixed bitrot in 4.2 myself (due to bug 661476):

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified template/en/default/admin/components/edit-common.html.tmpl
modified template/en/default/admin/components/edit.html.tmpl
modified template/en/default/admin/milestones/edit.html.tmpl
modified template/en/default/admin/versions/edit.html.tmpl
Committed revision 7972.


Committing to: bzr+ssh://[e-mail]/bugzilla/4.2/
modified template/en/default/admin/components/edit-common.html.tmpl
modified template/en/default/admin/components/edit.html.tmpl
modified template/en/default/admin/milestones/edit.html.tmpl
modified template/en/default/admin/versions/edit.html.tmpl
Committed revision 7938.