615656 - Ensure all mdObservers have default properties

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[cmtalbert]

Attachment: a patch for this

This patch puts the default properties of the mdObserver object into the prototype so that any objects that we might construct with the mdObserver will have these members by default.  (Important for later code reuse and refactoring, does not change current functionality).

Attaching patch.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Comment on attachment 494085 [details] [diff] [review]
a patch for this

> mdObserver.prototype = {
> 
>   /**
>+   * Set our default values for our internal properties
>+   */
>+  _opener : null,

As discussed on IRC I will remove the jsdoc comment before the check-in. We need to update all of our shared modules at once to expose docs of each individual property, and move constructor properties to the prototype. That's a follow-up.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/08b2a49e6ed9 (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/51449d10087c (1.9.2)
http://hg.mozilla.org/qa/mozmill-tests/rev/ecfd7c495ca5 (1.9.1)