Closed Bug 615656 Opened 14 years ago Closed 14 years ago

Ensure all mdObservers have default properties

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: cmtalbert, Assigned: cmtalbert)

References

Details

Attachments

(1 file)

Attached patch a patch for thisSplinter Review
This patch puts the default properties of the mdObserver object into the prototype so that any objects that we might construct with the mdObserver will have these members by default.  (Important for later code reuse and refactoring, does not change current functionality).

Attaching patch.
Attachment #494085 - Flags: review?(hskupin)
Comment on attachment 494085 [details] [diff] [review]
a patch for this

> mdObserver.prototype = {
> 
>   /**
>+   * Set our default values for our internal properties
>+   */
>+  _opener : null,

As discussed on IRC I will remove the jsdoc comment before the check-in. We need to update all of our shared modules at once to expose docs of each individual property, and move constructor properties to the prototype. That's a follow-up.
Attachment #494085 - Flags: review?(hskupin) → review+
Assignee: nobody → ctalbert
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: