615672 - quick_verify breaks when partner-repacks are disabled

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Syed Albiz [:salbiz]]

As part of bug 613320, a partial verification step was added to verify  en-US, a random locale and random partner repacks for en-US and the same random locale. However, the code to randomly select a partner-repack for verification does not deal cleanly with the absence of any partner-repacks to test.

Comment 1

[Syed Albiz [:salbiz]]

Attachment: dont bother with partner-repacks if they are disabled

cuts the check for partner-repacks in the case where they aren't there.

Comment 2

[Chris Cooper [:coop] (he/him)]

Comment on attachment 494136 [details] [diff] [review]
dont bother with partner-repacks if they are disabled

My only nit is using "unsigned" as a variable name, since I always assume it's a keyword. Consider making it more descriptive, but I won't block on that.

Comment 3

[Syed Albiz [:salbiz]]

Attachment: change variable name unsigned to unsigned_packages

Done, unsigned_packages is probably a good term to use, since that filters the list of container exes.

Comment 4

[[e-mail] (:bhearsum)]

Comment on attachment 494716 [details] [diff] [review]
change variable name unsigned to unsigned_packages

This is a bit hairy...can you unpack the filtering logic? It's really hard to read as is.

Comment 5

[Syed Albiz [:salbiz]]

Attachment: refactor fix

Did a test in staging with both partners enabled and disabled (just the make quick-verify step). Broken up the logic significantly.

Comment 6

[[e-mail] (:bhearsum)]

Comment on attachment 495150 [details] [diff] [review]
refactor fix

Much better.

Comment 7

[[e-mail] (:bhearsum)]

Comment on attachment 495150 [details] [diff] [review]
refactor fix

Landed on default: changeset:   1908:0ed4d242206b

Comment 8

[[e-mail] (:bhearsum)]

I think this bug is all done now.