615688 - Different alltabs toolbarbutton icon in the tab bar during toolbar customization

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Markus Stange [:mstange]]

Attachment: v1

The toolbaritem that's inserted during toolbar customization breaks the selectors that set a different icon for when the button is in the tab bar.

Comment 1

[Dão Gottwald [:dao]]

Comment on attachment 494140 [details] [diff] [review]
v1

>-#TabsToolbar > #alltabs-button:not([disabled="true"]):hover {
>+#TabsToolbar #alltabs-button:not([disabled="true"]):hover {
>   -moz-image-region: rect(0, 44px, 20px, 22px);
> }
> 
>-#TabsToolbar > #alltabs-button[type="menu"][open="true"]:not([disabled="true"]),
>-#TabsToolbar > #alltabs-button:not([disabled="true"]):hover:active {
>+#TabsToolbar #alltabs-button[type="menu"][open="true"]:not([disabled="true"]),
>+#TabsToolbar #alltabs-button:not([disabled="true"]):hover:active {
>   -moz-image-region: rect(0, 66px, 20px, 44px);
> }

The button isn't interactive while customizing, so these changes seem unnecessary.

Comment 2

[Markus Stange [:mstange]]

What do you mean with interactive?
Are you saying this bug should be wontfix?

Comment 3

[Dão Gottwald [:dao]]

(In reply to comment #2)
> What do you mean with interactive?

No hover feedback and it can't be pressed.

Comment 4

[Markus Stange [:mstange]]

Oh, I got it.

Comment 5

[Markus Stange [:mstange]]

Attachment: v2

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 503141 [details] [diff] [review]
v2

a=beltzner

Comment 7

[Markus Stange [:mstange]]

http://hg.mozilla.org/mozilla-central/rev/0b88752d6d29