Closed Bug 615688 Opened 9 years ago Closed 9 years ago

Different alltabs toolbarbutton icon in the tab bar during toolbar customization

Categories

(Firefox :: Theme, defect)

All
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 4.0b10

People

(Reporter: mstange, Assigned: mstange)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch v1 (obsolete) — Splinter Review
The toolbaritem that's inserted during toolbar customization breaks the selectors that set a different icon for when the button is in the tab bar.
Attachment #494140 - Flags: review?(dao)
Comment on attachment 494140 [details] [diff] [review]
v1

>-#TabsToolbar > #alltabs-button:not([disabled="true"]):hover {
>+#TabsToolbar #alltabs-button:not([disabled="true"]):hover {
>   -moz-image-region: rect(0, 44px, 20px, 22px);
> }
> 
>-#TabsToolbar > #alltabs-button[type="menu"][open="true"]:not([disabled="true"]),
>-#TabsToolbar > #alltabs-button:not([disabled="true"]):hover:active {
>+#TabsToolbar #alltabs-button[type="menu"][open="true"]:not([disabled="true"]),
>+#TabsToolbar #alltabs-button:not([disabled="true"]):hover:active {
>   -moz-image-region: rect(0, 66px, 20px, 44px);
> }

The button isn't interactive while customizing, so these changes seem unnecessary.
Attachment #494140 - Flags: review?(dao) → review-
What do you mean with interactive?
Are you saying this bug should be wontfix?
(In reply to comment #2)
> What do you mean with interactive?

No hover feedback and it can't be pressed.
Oh, I got it.
Attached patch v2Splinter Review
Attachment #494140 - Attachment is obsolete: true
Attachment #503141 - Flags: review?(dao)
Attachment #503141 - Flags: review?(dao) → review+
Attachment #503141 - Flags: approval2.0?
Comment on attachment 503141 [details] [diff] [review]
v2

a=beltzner
Attachment #503141 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/0b88752d6d29
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b10
You need to log in before you can comment on or make changes to this bug.