615735 - Clean up find bar close button CSS in the winstripe theme

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Patrick Walton (:pcwalton)]

Per Dão's comments in bug 601667 the CSS rules for the close button in the find bar in the winstripe theme should be cleaned up a bit.

Comment 1

[Patrick Walton (:pcwalton)]

Attachment: Proposed patch.

Proposed patch attached.

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 494197 [details] [diff] [review]
Proposed patch.

> .findbar-closebutton {
>-  border: 1px solid transparent;
>-  padding: 2px !important;
>+  border: none;
>+  padding: 3px;
>   list-style-image: url("chrome://global/skin/icons/close.png");
>   -moz-appearance: none;
>   -moz-image-region: rect(0, 16px, 16px, 0);
> }
> 
> .findbar-closebutton > .toolbarbutton-icon {
>-  -moz-margin-end: 0px !important;
>-  -moz-padding-end: 2px !important;
>-  -moz-padding-start: 2px !important;
>+  -moz-margin-end: 0px;
>+  padding: 0 2px;
> }

-moz-margin-end: 0px; is a no-op (i.e. should be dropped). padding: 0 2px; looks like it should be dropped in favor of padding: 3px 5px; on .findbar-closebutton. r=me with that. Thanks!

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 494197 [details] [diff] [review]
Proposed patch.

Patrick, please see comment 2.

Comment 4

[Patrick Walton (:pcwalton)]

Attachment: Proposed patch, version 2.

Oops. Duh, sorry. New version attached.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 497082 [details] [diff] [review]
Proposed patch, version 2.

a=beltzner

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/72311168b7d9