615745 - CookieServiceChild doesn't receive preference observer notifications

Status: RESOLVED FIXED

(Core :: Networking: Cookies, defect)

Description

[Josh Matthews [:jdm]]

From CookieServiceChild::CookieServiceChild:

>  prefBranch->AddObserver(kPrefCookieBehavior, this, PR_TRUE);
>  prefBranch->AddObserver(kPrefThirdPartySession, this, PR_TRUE);

PR_TRUE in this case means that we want a weak observer, but CookieServiceChild doesn't support weak references.

Comment 1

[Josh Matthews [:jdm]]

Attachment: Make CookieServiceChild add strong pref observers.

Comment 2

[Shawn Wilsher :sdwilsh]

(In reply to comment #0)
> PR_TRUE in this case means that we want a weak observer, but CookieServiceChild
> doesn't support weak references.
Eh, why doesn't it support weak references?

Comment 3

[Shawn Wilsher :sdwilsh]

Comment on attachment 494232 [details] [diff] [review]
Make CookieServiceChild add strong pref observers.

This would leak.  If we register them, we need to unregister them at the right times (which is why we use weak references in the first place; we don't need to worry about it)

Comment 4

[Josh Matthews [:jdm]]

Attachment: Make CookieServiceChild add strong pref observers.

Comment 5

[Josh Matthews [:jdm]]

Comment on attachment 494279 [details] [diff] [review]
Make CookieServiceChild add strong pref observers.

I am dumb; nevermind.

Comment 6

[Josh Matthews [:jdm]]

Attachment: Make CookieServiceChild support weak references.

Comment 7

[[e-mail]]

Comment on attachment 494281 [details] [diff] [review]
Make CookieServiceChild support weak references.

r=dwitte

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/e65c1b9d95fb