Closed
Bug 615781
Opened 14 years ago
Closed 14 years ago
"ASSERTION: frame must not be dirty" (nsIFrame::GetCaretBaseline) after turning a textbox into a radio button
Categories
(Core :: DOM: Editor, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b8
People
(Reporter: jruderman, Assigned: ehsan.akhgari)
References
Details
(Keywords: assertion, testcase)
Attachments
(3 files, 1 obsolete file)
|
381 bytes,
application/xhtml+xml
|
Details | |
|
1.55 KB,
text/plain
|
Details | |
|
2.56 KB,
patch
|
roc
:
review+
roc
:
approval2.0+
|
Details | Diff | Splinter Review |
###!!! ASSERTION: frame must not be dirty: '!NS_SUBTREE_DIRTY(this)', file layout/forms/nsFormControlFrame.cpp, line 93 ehsan, you fixed the last few of these ;)
|
Reporter | |
Comment 1•14 years ago
|
||
|
Assignee | |
Comment 2•14 years ago
|
||
Hmm, nsFocusManager::SetCaretVisible first calls SetCaretDOMSelection <http://mxr.mozilla.org/mozilla-central/source/dom/base/nsFocusManager.cpp#2039> and then shows/hides the caret. SetCaretDOMSelection calls StopBlinking and StartBlinking if mVisible. But if aVisible is false in SetCaretDOMSelection, that StartBlinking call is unneeded, right? So, roc, what do you think about extending SetCaretDOMSelection with a parameter calls aWillBeVisible or something like that, and only call StartBlinking if aWillBeVisible?
Can't we just hide the caret before moving it so mVisible is false?
|
|
Assignee | |
Comment 5•14 years ago
|
||
(In reply to comment #4) > Can't we just hide the caret before moving it so mVisible is false? Yes, probably a better idea. Thanks for suggesting it.
Attachment #494495 -
Attachment is obsolete: true
Attachment #495271 -
Flags: review?(roc)
Attachment #494495 -
Flags: review?(roc)
|
|
Assignee | |
Updated•14 years ago
|
Attachment #495271 -
Flags: approval2.0?
Attachment #495271 -
Flags: review?(roc)
Attachment #495271 -
Flags: review+
Attachment #495271 -
Flags: approval2.0?
Attachment #495271 -
Flags: approval2.0+
|
|
Assignee | |
Comment 6•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/c5e63ee00132
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
You need to log in
before you can comment on or make changes to this bug.
Description
•