Closed Bug 615833 Opened 9 years ago Closed 9 years ago

Change event should not be cancelable

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b9

People

(Reporter: mounir, Assigned: mounir)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Summary: Cancel event should not be cancelable → Change event should not be cancelable
Attached patch Patch v1 (obsolete) — Splinter Review
Assignee: nobody → mounir.lamouri
Status: NEW → ASSIGNED
Attachment #494355 - Flags: review?(Olli.Pettay)
Comment on attachment 494355 [details] [diff] [review]
Patch v1

What about http://mxr.mozilla.org/mozilla-central/source/layout/forms/nsListControlFrame.cpp#1633 ?

Perhaps you could add a helper method to nsContentUtils
to dispatch "change" event and call it wherever needed.
Attachment #494355 - Flags: review?(Olli.Pettay) → review-
Attached patch Patch v2Splinter Review
Oups, it's really hard to see that <select> has a change event in the specs (everytime the change event is mentioned, it's about the input element). This is now fixed.

I didn't add a helper in nsContentUtils given that it would only prevent developers to know that a change event should bubble and should not be cancelable (and it's very unlikely that someone will look for a helper to do that).
Attachment #494355 - Attachment is obsolete: true
Attachment #494368 - Flags: review?(Olli.Pettay)
Comment on attachment 494368 [details] [diff] [review]
Patch v2

r+, assuming other browsers (Opera and webkit) behave the same way.
Attachment #494368 - Flags: review?(Olli.Pettay) → review+
Comment on attachment 494368 [details] [diff] [review]
Patch v2

Opera and Webkit behave the same way.
Attachment #494368 - Flags: approval2.0?
Whiteboard: [passed-try][needs-approval]
Approval request: this make us follow the specs and what Webkit and Opera does. It should not provide web compat issues and the code change is trivial.
No longer blocks: 615697
Whiteboard: [passed-try][needs-approval] → [passed-try][needs-landing]
Pushed:
http://hg.mozilla.org/mozilla-central/rev/5370d662ae51
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [passed-try][needs-landing]
Target Milestone: --- → mozilla2.0b9
You need to log in before you can comment on or make changes to this bug.