615833 - Change event should not be cancelable

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 494355 [details] [diff] [review]
Patch v1

What about http://mxr.mozilla.org/mozilla-central/source/layout/forms/nsListControlFrame.cpp#1633 ?

Perhaps you could add a helper method to nsContentUtils
to dispatch "change" event and call it wherever needed.

Comment 3

[Mounir Lamouri (:mounir)]

Attachment: Patch v2

Oups, it's really hard to see that <select> has a change event in the specs (everytime the change event is mentioned, it's about the input element). This is now fixed.

I didn't add a helper in nsContentUtils given that it would only prevent developers to know that a change event should bubble and should not be cancelable (and it's very unlikely that someone will look for a helper to do that).

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 494368 [details] [diff] [review]
Patch v2

r+, assuming other browsers (Opera and webkit) behave the same way.

Comment 5

[Mounir Lamouri (:mounir)]

Comment on attachment 494368 [details] [diff] [review]
Patch v2

Opera and Webkit behave the same way.

Comment 6

[Mounir Lamouri (:mounir)]

Approval request: this make us follow the specs and what Webkit and Opera does. It should not provide web compat issues and the code change is trivial.

Comment 7

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/5370d662ae51