Closed Bug 615846 Opened 14 years ago Closed 14 years ago

correct name/test_markup.html, extend events debugging in mochitests

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla2.0b8

People

(Reporter: surkov, Assigned: surkov)

Details

(Keywords: access)

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
patch is against the trunk
Attachment #494358 - Flags: review?(fherrera)
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
Attached patch patch2Splinter Review
a bit better version
Attachment #494358 - Attachment is obsolete: true
Attachment #494390 - Flags: review?(fherrera)
Attachment #494358 - Flags: review?(fherrera)
Comment on attachment 494390 [details] [diff] [review]
patch2

Nice.

It would be nice to add also:

var gA11yEventDumpToAppConsole = false;
...
var consoleService = Components.classes["@mozilla.org/consoleservice;1"]
                                 .getService(Components.interfaces.nsIConsoleService);
...

  logToAppConsole: function logger_logToAppConsole(aInfo)
  {
    if (gA11yEventDumpToAppConsole)
        consoleService.logStringMessage("events: " + aInfo);
  }


but it's up to you as we already have two dumping methods.

r=me
Attachment #494390 - Flags: review?(fherrera) → review+
landed with comment addressed - http://hg.mozilla.org/mozilla-central/rev/d25494ae4c3b
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: