615878 - 1.9.1/1.9.2 nightlies were built off of the relbranch

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[[e-mail] (:bhearsum)]

...which gave them "official" version numbers (3.5.16/3.6.13) with nightly branding, which is quite confusing. Probably related to the recent nightly scheduler changes.

It's probably not a coincidence that the current tip of both repositories is the relbranch but confusingly they didn't build from tip but rather the revs tagged with _RELEASE, which are currently the 3rd most recent rev.

Comment 1

[[e-mail] (:bhearsum)]

From scheduler_master's log:
2010-12-01 03:03:19-0800 [-] lastGoodRev: took 0.09 seconds to run; returned None
2010-12-01 03:03:19-0800 [-] lastChangeset returned FIREFOX_3_5_16_RELEASE
2010-12-01 03:03:23-0800 [-] lastNightlyRevision was 26016fb6587015a1e0d8017ced5f43b3977ada5b
2010-12-01 03:03:23-0800 [-] mozilla-1.9.1 nightly: Creating buildset with sourcestamp ['FIREFOX_3_5_16_RELEASE', "in 'releases/mozilla-1.9.1'"]
2010-12-01 03:03:23-0800 [-] mozilla-1.9.1 nightly: propfunc returned {'buildid': '20101201030323'}
2010-12-01 03:03:23-0800 [-] mozilla-1.9.1 nightly: propfunc returned {'builduid': 'a950285c3f78406ba6c2a3ea6eae7038'}

Comment 2

[Chris AtLee [:catlee]]

Patch incoming

Comment 3

[Chris AtLee [:catlee]]

Attachment: Ignore DONTBUILD and changes without revlinks

This happened because the release sendchanges are on the release/mozilla-1.9.{1,2} branches, and show up the in changes table on that branch.  Since these were the latest changes on those branches, they were chosen for the nightly builds.

This patch ignores changes without a revlink, as well as DONTBUILD changes for the purposes of figuring out what the "latest" change on a branch is.

Comment 4

[Chris AtLee [:catlee]]

Comment on attachment 494418 [details] [diff] [review]
Ignore DONTBUILD and changes without revlinks

changeset:   1180:3fb5af3ae220

Comment 5

[Chris AtLee [:catlee]]

Will check tomorrow to verify.