Closed Bug 615935 Opened 9 years ago Closed 9 years ago

cancel any complex text composition for a Cocoa NPAPI plugin when it doesn't return kNPEventStartIME for a key down event

Categories

(Core :: Widget: Cocoa, defect)

All
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: jaas, Assigned: jaas)

Details

Attachments

(1 file)

We should cancel any complex text composition for a Cocoa NPAPI plugin when it doesn't return kNPEventStartIME for a key down event. Right now we just have a comment about doing it in ChildView's '-(void)keyDown:' method:

5369       if (!mPluginComplexTextInputRequested) {
5370         // Ideally we'd cancel any TSM composition here.
5371         return;
5372       }
blocking2.0: --- → betaN+
Attached patch fix v1.0Splinter Review
Attachment #494584 - Flags: review?(smichaud)
Comment on attachment 494584 [details] [diff] [review]
fix v1.0

Looks fine to me.
Attachment #494584 - Flags: review?(smichaud) → review+
Attachment #494584 - Flags: approval2.0+
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/e42651bbc73e
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.