Closed Bug 616061 Opened 11 years ago Closed 10 years ago
Disable TLS in jemalloc on Android
The use of TLS breaks startup on Win32 builds, mega-libxul builds, and seemingly any other build configuration where I'm trying to do something interesting. Also, we don't need TLS anyway. (or so I've heard)
Attachment #494610 - Flags: review?(vladimir)
Comment on attachment 494610 [details] [diff] [review] Disable jemalloc TLS on Android Sure, I'll review my own patch! ;-)
Attachment #494610 - Flags: review?(vladimir) → review+
(In reply to comment #1) > Comment on attachment 494610 [details] [diff] [review] > Disable jemalloc TLS on Android > > Sure, I'll review my own patch! ;-) Heh. Honest - I thought it was mine. Looked similar since there's not a lot of ways to do this anyway. (but mine #ifdef's ANDROID and goes higher into the file..)
What's the reward/risk here?
Comment on attachment 494610 [details] [diff] [review] Disable jemalloc TLS on Android risk/reward is that we think that we don't break currently by sheer coincidence; permuting any number of things causes us to break here. Unfortunately we don't understand /why/ it's breaking, which would be useful information.
Attachment #494610 - Flags: approval2.0? → approval2.0+
Ready to check in. I changed the author to vlad with r=me since this is in fact vlad's patch. (but I wrote an almost identical one with the code in a different place before)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b11
You need to log in before you can comment on or make changes to this bug.