616061 - Disable TLS in jemalloc on Android

Status: RESOLVED FIXED

(Core :: Memory Allocator, defect)

Description

[Michael Wu [:mwu]]

Attachment: Disable jemalloc TLS on Android

The use of TLS breaks startup on Win32 builds, mega-libxul builds, and seemingly any other build configuration where I'm trying to do something interesting. Also, we don't need TLS anyway. (or so I've heard)

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 494610 [details] [diff] [review]
Disable jemalloc TLS on Android

Sure, I'll review my own patch! ;-)

Comment 2

[Michael Wu [:mwu]]

(In reply to comment #1)
> Comment on attachment 494610 [details] [diff] [review]
> Disable jemalloc TLS on Android
> 
> Sure, I'll review my own patch! ;-)

Heh. Honest - I thought it was mine. Looked similar since there's not a lot of ways to do this anyway. (but mine #ifdef's ANDROID and goes higher into the file..)

Comment 3

[Benjamin Smedberg]

What's the reward/risk here?

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 494610 [details] [diff] [review]
Disable jemalloc TLS on Android

risk/reward is that we think that we don't break currently by sheer coincidence; permuting any number of things causes us to break here.

Unfortunately we don't understand /why/ it's breaking, which would be useful information.

Comment 5

[Michael Wu [:mwu]]

Attachment: hg patch ready patch

Comment 6

[Michael Wu [:mwu]]

Ready to check in. I changed the author to vlad with r=me since this is in fact vlad's patch. (but I wrote an almost identical one with the code in a different place before)

Comment 7

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/0fb025a84958