Closed
Bug 616125
Opened 14 years ago
Closed 13 years ago
E4X uses a non-RC write barrier to overwrite a field holding an RCObject
Categories
(Tamarin Graveyard :: Garbage Collection (mmGC), defect, P1)
Tamarin Graveyard
Garbage Collection (mmGC)
Tracking
(Not tracked)
VERIFIED
FIXED
Q3 11 - Serrano
People
(Reporter: treilly, Unassigned)
References
Details
(Whiteboard: WE 2782377)
Attachments
(3 files)
|
461 bytes,
patch
|
lhansen
:
review+
|
Details | Diff | Splinter Review |
|
548 bytes,
patch
|
treilly
:
review+
lhansen
:
superreview+
|
Details | Diff | Splinter Review |
|
5.47 KB,
patch
|
treilly
:
review+
|
Details | Diff | Splinter Review |
need to clear with a RC write barrier first
Attachment #494710 -
Flags: review?(lhansen)
|
Reporter | |
Updated•14 years ago
|
Assignee: nobody → treilly
Status: NEW → ASSIGNED
|
||
Comment 1•14 years ago
|
||
Comment on attachment 494710 [details] [diff] [review] clear it (Ravings about awful hacks mostly elided.)
Attachment #494710 -
Flags: review?(lhansen) → review+
|
|
Reporter | |
Comment 2•14 years ago
|
||
The idea of a template, ie: GCMember<Stringp, E4XNodeAux> m_nameOrAux; has come up before. Which would take care of all these details under the covers (including any bit twiddling).
|
|
Reporter | |
Comment 3•14 years ago
|
||
http://hg.mozilla.org/tamarin-redux/rev/d7ab3108d0fc
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•13 years ago
|
Flags: flashplayer-bug+
|
||
Comment 4•13 years ago
|
||
WE #2782377 surfaced it up.
Attachment #526797 -
Flags: superreview?(lhansen)
Attachment #526797 -
Flags: review?(treilly)
|
|
||
Updated•13 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Reporter | |
Updated•13 years ago
|
Attachment #526797 -
Flags: review?(treilly) → review+
|
|
||
Comment 5•13 years ago
|
||
Comment on attachment 526797 [details] [diff] [review] One more place needs WBRC_NULL We should expedite work on Tommy's idea for a structured way of dealing with these kinds of unions.
Attachment #526797 -
Flags: superreview?(lhansen) → superreview+
|
|
Reporter | |
Comment 6•13 years ago
|
||
http://hg.mozilla.org/tamarin-redux/rev/de2739a7f6f6
Status: REOPENED → RESOLVED
Closed: 14 years ago → 13 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 7•13 years ago
|
||
Re-opening, need acceptance tests that hit setNotification
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Reporter | |
Updated•13 years ago
|
Assignee: treilly → nobody
Flags: in-testsuite-
|
|
Reporter | |
Comment 8•13 years ago
|
||
I set the in-testsuite flag to a "-", reopened and reset assignee to default. Hoping qe picks this up...
|
||
Comment 9•13 years ago
|
||
confirmed that with tr rev 6202 this testcase causes an assert to be thrown, and with 6203 it executes properly.
Attachment #528308 -
Flags: review?(treilly)
|
|
Reporter | |
Updated•13 years ago
|
Attachment #528308 -
Flags: review?(treilly) → review+
|
||
Comment 10•13 years ago
|
||
changeset: 6214:eeb68bddb214 user: Brent Baker <brbaker@adobe.com> summary: Bug 616125: add testing around XML.setNotification() (r=treilly) http://hg.mozilla.org/tamarin-redux/rev/eeb68bddb214
|
|
Reporter | |
Updated•13 years ago
|
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
|
|
||
Updated•13 years ago
|
Status: RESOLVED → VERIFIED
Flags: in-testsuite- → in-testsuite+
|
|
||
Comment 11•13 years ago
|
||
changeset: 6224:60f2e1775c0e user: Brent Baker <brbaker@adobe.com> summary: Bug 616125: skip testcase when recompiled with -ES http://hg.mozilla.org/tamarin-redux/rev/60f2e1775c0e
You need to log in
before you can comment on or make changes to this bug.
Description
•