Closed Bug 616256 Opened 9 years ago Closed 9 years ago

Don't stat files on directory enumeration on windows

Categories

(Core :: XPCOM, defect)

x86
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- -

People

(Reporter: taras.mozilla, Assigned: taras.mozilla)

References

Details

Attachments

(1 file)

This cuts down number of stat()s by 4x during startup. To fix slow plugin enumeration we either need to take this patch or do custom windows directory enumeration in the plugin code.

This patch passed try
Attachment #494795 - Flags: review?(benjamin)
Attachment #494795 - Flags: review+
blocking2.0: --- → ?
Comment on attachment 494795 [details] [diff] [review]
dont stat on readdir()

Yeah, this code dates back to the original landing in CVS, and I can't think why we'd need it now. Here's hoping, anyway!
Attachment #494795 - Flags: review?(benjamin) → review+
Keywords: checkin-needed
blocking2.0: ? → -
Attachment #494795 - Flags: approval2.0+
http://hg.mozilla.org/mozilla-central/rev/eb947172ce38
Status: NEW → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Assignee: nobody → tglek
You need to log in before you can comment on or make changes to this bug.