616300 - crash [@ nsPrintEngine::DoCommonPrint(int, nsIPrintSettings*, nsIWebProgressListener*)]

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[Wayne Mery (:wsmwk)]

crash [@ nsPrintEngine::DoCommonPrint(int, nsIPrintSettings*, nsIWebProgressListener*)]

bp-7436940f-cd56-48bd-8dca-f2c812101114 (laura)
Mac OS X
10.4.11 8S2167
x86
GenuineIntel family 6 model 14 stepping 8
EXC_BAD_ACCESS / KERN_PROTECTION_FAILURE
0x44
0	XUL	nsPrintEngine::DoCommonPrint	
1	XUL	nsPrintEngine::CommonPrint	layout/printing/nsPrintEngine.cpp:447
2	XUL	nsPrintEngine::Print	layout/printing/nsPrintEngine.cpp:755
3	XUL	DocumentViewerImpl::Print	layout/base/nsDocumentViewer.cpp:3746
4	XUL	nsGlobalWindow::Print	dom/base/nsGlobalWindow.cpp:4597 

bp-74e4dbbe-42f9-4e43-8ed2-9b0102101122
Windows NT
5.1.2600 Service Pack 2
x86
AuthenticAMD family 6 model 10 stepping 0
EXCEPTION_ACCESS_VIOLATION_READ
0x44
0	xul.dll	nsPrintEngine::DoCommonPrint	layout/printing/nsPrintEngine.cpp:629
1	xul.dll	nsPrintEngine::CommonPrint	layout/printing/nsPrintEngine.cpp:447
2	xul.dll	nsPrintEngine::Print	layout/printing/nsPrintEngine.cpp:755
3	xul.dll	DocumentViewerImpl::Print	layout/base/nsDocumentViewer.cpp:3746
4	xul.dll	nsGlobalWindow::Print	dom/base/nsGlobalWindow.cpp:4597 

bp-e43ee349-2093-4e0a-b623-999662101114 thunderbird

Comment 1

[timeless]

628        // The user might have changed shrink-to-fit in the print dialog, so update our copy of its state
629        mPrt->mPrintSettings->GetShrinkToFit(&mPrt->mShrinkToFit);
630      } else {
631        rv = NS_ERROR_GFX_NO_PRINTROMPTSERVICE;
632      }
633    } else {
634      // Call any code that requires a run of the event loop.
635      rv = mPrt->mPrintSettings->SetupSilentPrinting();

I believe mPrintSettings is null

Comment 2

[timeless]

actually,
        rv = printPromptService->ShowPrintDialog(domWin, wbp,
                                                 mPrt->mPrintSettings);

shows a dialog which spins an event loop, which means that the assumptions about objects here cease to be valid.

Comment 3

[timeless]

Attachment: patch

Comment 4

[timeless]

Attachment: compiling

Comment 5

[timeless]

Attachment: actually qrefreshed

sorry, i didn't realize qrefresh hadn't finished *sigh*

Comment 6

[Jonathan Watt [:jwatt]]

Pushed http://hg.mozilla.org/mozilla-central/rev/916b65373ba2