Make nsISMILAttr::ValueFromString() only set aPreventCachingOfSandwich outparam in the PR_TRUE case

NEW
Unassigned

Status

()

defect
9 years ago
9 years ago

People

(Reporter: dholbert, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Per discussion with jwatt in #svg, we can simplify the nsSMILAnimationFunction::ParseAttr & nsISMILAttr::ValueFromString logic a bit by making nsISMILAttr::ValueFromString behave more like nsSMILAnimationFunction::ParseAttr.

Currently nsSMILAnimationFunction::ParseAttr only sets its aPreventCachingOfSandwich outparam when it needs to be set to PR_TRUE.  (This lets us pass the same initially-false outparam into ParseAttr multiple times, and then check it for trueness at the end to see if any of the parsed values need us to prevent caching the sandwich.)

Our impls for nsISMILAttr::ValueFromString should behave like that, too.  If we like, then, we can then even pass ParseAttr's outparam directly to ValueFromString.
You need to log in before you can comment on or make changes to this bug.