616365 - Update the AAQ process to reflect confirming users, not questions

Status: VERIFIED FIXED

(support.mozilla.org :: Questions, task, P3)

Description

[Paul Craciunoiu [:paulc]]

Now that we're registering users through kitsune, AAQ can benefit from the confirmation step to actually be on _users_ as opposed to _questions.

We need to update the text and email accordingly to let the user now that:
* They need to confirm their email in order for their question to show up
* They will only be able to post this one question until they confirm their email
* We should probably log them in during the confirmation step as well, so they can ask other questions/do whatever.

This also means removing the confirmation step for already-active users, making that experience better for them. Could be a separate bug :)

Comment 1

[James Socol [:jsocol, :james]]

This is a "nice to have" but not necessary for 2.4.

(In reply to comment #0)
> * We should probably log them in during the confirmation step as well, so they
> can ask other questions/do whatever.

I'm not even sure we can do that the way Django authenticates people, but showing a login form on the successful-confirmation page makes me feel safer anyway.

> This also means removing the confirmation step for already-active users, making
> that experience better for them. Could be a separate bug :)

That's trivially part of this. We strip out the code that sends the question confirmation and eventually remove the columns as well, and only show questions where question.creator.is_active = True.

Comment 2

[Paul Craciunoiu [:paulc]]

(In reply to comment #1)
> 
> I'm not even sure we can do that the way Django authenticates people, but
> showing a login form on the successful-confirmation page makes me feel safer
> anyway.
Yeah. Probably safer and also... possible!

Comment 3

[James Socol [:jsocol, :james]]

Let's do this over time to make sure we handle unconfirmed questions correctly.

Comment 4

[Paul Craciunoiu [:paulc]]

https://github.com/jsocol/kitsune/commit/43760e1d53afd3998c37629023b8c618e1f4adda

(In reply to comment #3)
> Let's do this over time to make sure we handle unconfirmed questions correctly.
Yep, so, for QA, here's what's happening now:

* Only _new_ questions for active users show up directly.
* Old unconfirmed questions still need to be confirmed through the same process as before
* And inactive users asking new questions will be sent the same email they are sent on registration, and taken to a page which tells them to confirm their email before their question will appear in the list.

Please don't hesitate to ask if you have questions about testing this.

Comment 5

[Rebecca Billings [:rbillings]]

Verified all except old confirmed questions- which will be done after the prod data dump

Comment 6

[Rebecca Billings [:rbillings]]

Verified old confirmed questions after prod data dump- bring up confirmation as before, questions added to /questions