616368 - Force a checkpoint after schema creation or upgrade

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Marco Bonardo [:mak]]

Just for added safety.
To do this I'll have to cleanup the migration code a bit so that:
1. I remove an empty useless transaction for normal startups
2. I have a single point to put the forcing

This means I want to remove all old migration code that comes from Firefox 3 alphas (finally!), or at least, the most part.

Comment 1

[Marco Bonardo [:mak]]

Attachment: patch v1.0

Comment 2

[Shawn Wilsher :sdwilsh]

Comment on attachment 494920 [details] [diff] [review]
patch v1.0

>+++ b/toolkit/components/places/src/nsNavHistory.cpp
>   // Ensure that temp tables are held in memory, not on disk.  We use temp
>   // tables mainly for fsync and I/O reduction.
>-  rv = mDBConn->ExecuteSimpleSQL(NS_LITERAL_CSTRING(
>+  nsresult rv = mDBConn->ExecuteSimpleSQL(NS_LITERAL_CSTRING(
The comment here is clearly outdated!

>+  // Grow places in 10MB increments
>+  mDBConn->SetGrowthIncrement(10 * 1024 * 1024, EmptyCString());
I should have caught this before.  Can we add a BYTES_PER_MEGABYTE constant somewhere?
nit: (void)

r=sdwilsh

Comment 3

[Marco Bonardo [:mak]]

Attachment: patch v1.1

Comment 4

[Marco Bonardo [:mak]]

http://hg.mozilla.org/projects/places/rev/0b18344e65ca

Comment 5

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/0b18344e65ca