Closed
Bug 616368
Opened 14 years ago
Closed 14 years ago
Force a checkpoint after schema creation or upgrade
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla2.0b9
People
(Reporter: mak, Assigned: mak)
Details
(Whiteboard: [fixed-in-places])
Attachments
(1 file, 1 obsolete file)
|
22.75 KB,
patch
|
Details | Diff | Splinter Review |
Just for added safety.
To do this I'll have to cleanup the migration code a bit so that:
1. I remove an empty useless transaction for normal startups
2. I have a single point to put the forcing
This means I want to remove all old migration code that comes from Firefox 3 alphas (finally!), or at least, the most part.
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #494920 -
Flags: review?(sdwilsh)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 494920 [details] [diff] [review]
patch v1.0
>+++ b/toolkit/components/places/src/nsNavHistory.cpp
> // Ensure that temp tables are held in memory, not on disk. We use temp
> // tables mainly for fsync and I/O reduction.
>- rv = mDBConn->ExecuteSimpleSQL(NS_LITERAL_CSTRING(
>+ nsresult rv = mDBConn->ExecuteSimpleSQL(NS_LITERAL_CSTRING(
The comment here is clearly outdated!
>+ // Grow places in 10MB increments
>+ mDBConn->SetGrowthIncrement(10 * 1024 * 1024, EmptyCString());
I should have caught this before. Can we add a BYTES_PER_MEGABYTE constant somewhere?
nit: (void)
r=sdwilsh
Attachment #494920 -
Flags: review?(sdwilsh)
Attachment #494920 -
Flags: review+
Attachment #494920 -
Flags: approval2.0+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Attachment #494920 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 4•14 years ago
|
||
Whiteboard: [fixed-in-places]
|
|
Assignee | |
Comment 5•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b9
You need to log in
before you can comment on or make changes to this bug.
Description
•