Closed Bug 616430 Opened 14 years ago Closed 14 years ago

Add-ons Manager hides information that restart is needed after adding

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 553460

People

(Reporter: bj, Unassigned)

Details

(Whiteboard: [AOMTestday])

User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:2.0b8pre) Gecko/20101202 Firefox/4.0b8pre
Build Identifier: 4.0b8pre (installed from nightly on 3 December 2010)

When an add-on is installed there is a notification near the tab bar for the restart. I ignored that because I first wanted to check all of my tabs (restart doesn't restore all the state).

After I checked the tabs, I couldn't find where to restart. Going to the Add-ons Manager there was no "restart needed", no tab with list of the changes that were pending waiting for a restart, and "check for updates" said "no updates found".

Reproducible: Always

Steps to Reproduce:
1.Install add-on.
2.Ignore "needs restart" notification near tab bar.
3.Visit Add-one Manager.
Actual Results:  
No visible indication that a restart is needed (or restart link) unless you first select the correct sub-item (Extension or Appearance) and scroll to and look at the correct item that needs a restart,

Expected Results:  
1) At the top of the Add-ons Manager there should be a "restart needed" indicator and restart link.

2) When you select "check for updates" it should say "no updates needed" because there is an update in process.

3) There should be an option on the left for "updates pending" (like Firefox 3.*, I don't remember the exact wording). This would allow all pending changes to be reviewed so some can be removed if you don't want them all.
Whiteboard: [AOMTestday]
Version: 1.9.2 Branch → Trunk
I think that most of the feature addressed by comment 0 is actually part of bug 553460. Dupe?
Whiteboard: [AOMTestday] → [AOMTestday][DUPEME]
The tab you installed from should show the extension puzzle icon next to the site identity bar, clicking it should bring back the notification and offer to restart.

In the add-ons manager the extension you added should be listed with links at the top to restart or undo.

If either of these things are not happening then there is a bug we don't know about otherwise I tend to agree this is probably best duped to bug 553460 where we hope to make the need to restart more obvious in the future.
(In reply to comment #2)
> The tab you installed from should show the extension puzzle icon next to the
> site identity bar, clicking it should bring back the notification and offer to
> restart.

From a little more testing the icon is there, but there are several problems with the icon:

1) I didn't notice the extra icon before. It doesn't stand out -- especially since it is the same icon as the favicon for the add-on web pages.

2) If I had noticed it I wouldn't have known what it meant. There's nothing about it that shouts "click here to do something important" instead of "I'm just eye candy".

3) The icon doesn't always connect to a related page. If you load an add-on from a file the icon gets placed with whatever tab happened to be in front. If you ignore it at that point you need to search through all your tabs to find it again.

4) If you close the tab (as I often do when reviewing tabs to see if it is an appropriate time for for a restart) the indicator goes away.

And what I find most annoying about that link: It just restarts and applies all pending changes rather than giving you a chance to look at the list and undo any that aren't appropriate.

> In the add-ons manager the extension you added should be listed with links at
> the top to restart or undo.
> 
> If either of these things are not happening then there is a bug we don't know
> about otherwise I tend to agree this is probably best duped to bug 553460 where
> we hope to make the need to restart more obvious in the future.

It does look like this bug can fall under bug 553460.
Based on Comment 3, duping this to Bug 553460
Status: UNCONFIRMED → RESOLVED
Closed: 14 years ago
Resolution: --- → DUPLICATE
Whiteboard: [AOMTestday][DUPEME] → [AOMTestday]
You need to log in before you can comment on or make changes to this bug.