Closed
Bug 616434
Opened 14 years ago
Closed 14 years ago
Should be separating lines between the rows in the table of the details view
Categories
(Toolkit :: Add-ons Manager, defect)
Tracking
()
VERIFIED
FIXED
mozilla2.0b10
Tracking | Status | |
---|---|---|
blocking2.0 | --- | final+ |
People
(Reporter: bj, Assigned: Unfocused)
Details
(Keywords: polish, Whiteboard: [AOMTestday][softblocker])
Attachments
(2 files)
204.76 KB,
image/png
|
Details | |
898 bytes,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:2.0b8pre) Gecko/20101202 Firefox/4.0b8pre
Build Identifier: 4.0b8pre (installed from nightly on 3 December 2010)
Looking at the details of an extension (clicking the "More" link), the table of information at the bottom is hard to parse because the first and second column can be very far apart.
The distance between the columns varies depending on the add-on, but in some cases it is almost 8 cm.
Reproducible: Always
Steps to Reproduce:
1. Purchase and install a monitor with a large horizontal resolution.
2. Run Firefox full-screen.
3. Install an add-on.
4. Open Add-ons Manager
5. Click "Extension" or "Appearance" as appropriate.
6. Click a "More" link.
7. Scroll to the bottom of the display.
Actual Results:
There is a table at the bottom with rows labeled "Last Updates", "Automatic Updates", etc. The first and second columns are separated so widely it is hard to visually correlate the items in the first column with the second column,
Expected Results:
There should be at most a couple of centimeters between the end of the first column and the start of the second column.
Reporter | ||
Comment 1•14 years ago
|
||
Reporter | ||
Updated•14 years ago
|
Whiteboard: [AOMTestday]
Version: 1.9.2 Branch → Trunk
Reporter | ||
Updated•14 years ago
|
Summary: Too much horizontal space in summary table at bottom on single add-on view → Add-ons Manager: Too much horizontal space in summary table at bottom on single add-on view
Comment 2•14 years ago
|
||
One possible solution would be to align it with the add-on description, which is shown above.
Updated•14 years ago
|
Summary: Add-ons Manager: Too much horizontal space in summary table at bottom on single add-on view → Too much horizontal space between the columns at bottom of the details view
Comment 3•14 years ago
|
||
I think the biggest problem here is that there should be lines between the rows as there are on other platforms. Adding those would probably make it far easier to read the table.
blocking2.0: --- → final+
OS: All → Linux
Summary: Too much horizontal space between the columns at bottom of the details view → Should be separating lines between the rows in the table of the details view
Comment 4•14 years ago
|
||
Looks like to be a Linux only bug. Other platforms have the lines.
But what about the horizontal space? Shouldn't have a better left-align of the values?
Reporter | ||
Comment 5•14 years ago
|
||
I don't disagree that horizontal lines would be useful, but I still think it would be easier to read with less horizontal space between the columns. Does anyone think it looks better with that much white space?
Summary: Should be separating lines between the rows in the table of the details view → Should be separating lines between the rows in the table of the details view, and less horizontal space between the columns
Comment 6•14 years ago
|
||
(In reply to comment #5)
> I don't disagree that horizontal lines would be useful, but I still think it
> would be easier to read with less horizontal space between the columns. Does
> anyone think it looks better with that much white space?
Readability rather than whitespace is the problem. Aligning information horizontally means headings (on the left) are easier to associate with their values (on the right). Blair, can you add these lines?
Updated•14 years ago
|
Assignee: nobody → ddahl
Updated•14 years ago
|
Assignee: ddahl → nobody
Updated•14 years ago
|
Whiteboard: [AOMTestday] → [AOMTestday][good first bug]
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → bmcbride
Status: NEW → ASSIGNED
Summary: Should be separating lines between the rows in the table of the details view, and less horizontal space between the columns → Should be separating lines between the rows in the table of the details view
Assignee | ||
Comment 7•14 years ago
|
||
Turns out there were already lines, but they were just the same color as the background for some themes.
Attachment #502687 -
Flags: review?(dtownsend)
Assignee | ||
Updated•14 years ago
|
Whiteboard: [AOMTestday][good first bug] → [AOMTestday][has patch][needs review Mossop]
Updated•14 years ago
|
Whiteboard: [AOMTestday][has patch][needs review Mossop] → [AOMTestday][has patch][needs review Mossop][soft blocker]
Updated•14 years ago
|
Attachment #502687 -
Flags: review?(dtownsend) → review+
Updated•14 years ago
|
Whiteboard: [AOMTestday][has patch][needs review Mossop][soft blocker] → [AOMTestday][has patch][soft blocker]
Assignee | ||
Comment 8•14 years ago
|
||
Landed: https://hg.mozilla.org/mozilla-central/rev/5c4d8d8417b8
I wouldn't bother with a litmus test for this one, since its just styling.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Flags: in-litmus-
Resolution: --- → FIXED
Whiteboard: [AOMTestday][has patch][soft blocker] → [AOMTestday][soft blocker]
Target Milestone: --- → mozilla2.0b10
Updated•14 years ago
|
Whiteboard: [AOMTestday][soft blocker] → [AOMTestday][softblocker]
Comment 9•14 years ago
|
||
Verified fixed with Mozilla/5.0 (X11; Linux i686; rv:2.0b10pre) Gecko/20110112 Firefox/4.0b10pre
Status: RESOLVED → VERIFIED
Reporter | ||
Comment 10•14 years ago
|
||
Yes, the table is easier to read with lines that are a different color from the background. However, I still think the text in the two columns are too far apart (on a wide, high-resolution screen). It's just plain ugly to have the white space between the columns be twice the width of the information displayed.
Comment 11•14 years ago
|
||
Can you please file a new bug? Thanks.
You need to log in
before you can comment on or make changes to this bug.
Description
•