616457 - Update check also checks for updates of removed add-ons

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101201 Firefox/4.0b8pre ID:20101201030318

When an extension has been removed within a browsing session and an update check is performed without a restart, we also check for updates for the partially removed extensions. I have seen that while verifying bug 308522.

Steps:
1. Install an older version of an add-on (see URL)
2. Restart the browser and remove the add-on from within the add-ons manager
3. Check for updates

After step 3 we expose an available update to the UI, which shouldn't happen.

Comment 1

[Dave Townsend [:mossop]]

Good catch, I suspect in the worst case a background update check will actually update an extension waiting to be uninstalled without the user's knowledge.

Comment 2

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Straightforward fix, marks add-ons as un-upgradable when they are pending uninstall.

Comment 3

[Robert Strong (they/them - no direct email)]

Comment on attachment 501031 [details] [diff] [review]
patch rev 1

Looks straightforward enough... just one minor nit

>diff --git a/toolkit/mozapps/extensions/XPIProvider.jsm b/toolkit/mozapps/extensions/XPIProvider.jsm
>--- a/toolkit/mozapps/extensions/XPIProvider.jsm
>+++ b/toolkit/mozapps/extensions/XPIProvider.jsm
>@@ -6478,24 +6478,26 @@ function AddonWrapper(aAddon) {
>   this.__defineGetter__("permissions", function() {
>     let permissions = 0;
>     if (!aAddon.appDisabled) {
>       if (aAddon.userDisabled)
>         permissions |= AddonManager.PERM_CAN_ENABLE;
>       else if (aAddon.type != "theme")
>         permissions |= AddonManager.PERM_CAN_DISABLE;
>     }
>-    if (aAddon._installLocation) {
>-      if (!aAddon._installLocation.locked) {
>-        if (!aAddon._installLocation.isLinkedAddon(aAddon.id))
>-          permissions |= AddonManager.PERM_CAN_UPGRADE;
>-
>-        if (!aAddon.pendingUninstall)
>-          permissions |= AddonManager.PERM_CAN_UNINSTALL;
>-      }
>+    // Add-ons that have no install location (those that are pending install) or
>+    // that are in locked install locations or are pending uninstall cannot be
>+    // upgraded or uninstalled
nit: too may or's
// Add-ons that have no install location (those that are pending install),
// are in locked install locations, or are pending uninstall cannot be
// upgraded or uninstalled

Also, it would be a good thing if the comment made it clear if only add-ons that are pending install don't have an install location.

Comment 4

[Dave Townsend [:mossop]]

Landed: http://hg.mozilla.org/mozilla-central/rev/0548fd8f2b18

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b9pre) Gecko/20110109 Firefox/4.0b9pre ID:20110109030350