616502 - Arrows of the arrow panels do not show sometimes

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[gadjo]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101203 Firefox/4.0b8pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101203 Firefox/4.0b8pre

In some cases there is no arrow in invalid popup form (which is now arrow panel)

Reproducible: Always

Steps to Reproduce:
1. Open the URL
2. Click submit
Actual Results:  
The invalid form arrow panel doesn't have and arrow (actually it has for a very short time and then dissapears)

Expected Results:  
Arrow panel should have an arrow

The arrow appears when the width or margin property is removed from the #container

Comment 1

[gadjo]

Attachment: No arrow in arrow panel

Comment 2

[Mounir Lamouri (:mounir)]

Does it happen everytime for a given form or it seems fully random?

Comment 3

[gadjo]

If there are both rules in CSS there is no arrow everytime, if I remove one declaration there's correct behaviour everytime

Comment 4

[gadjo]

Attachment: Simplified test cases with different CSS

Comment 5

[Mounir Lamouri (:mounir)]

The three last ones seem to have an arrow panel (at least on Mac) but I can confirm the other ones doesn't work.

Comment 6

[Mounir Lamouri (:mounir)]

So, the arrows of the arrow panels for some reasons do not show sometimes. It's very visible now because it's now used to show the error message when the user tries to submit an invalid form.

I guess it should block given that it's a bug in a new feature (arrow panel) which has direct consequence for another new feature (HTML5 Forms validation). The bug isn't critical thought.

Comment 7

[Neil Deakin]

This is because the arrow position calculation isn't taking account that the anchor input elements are inside child frames.

I guess it should either be using screen coordinates or adding the iframe's offset to calculations.

Comment 8

[Neil Deakin]

Attachment: Use screen coordinates

This patch changes arrow position calculation to use screen coordinates instead of client coordinates.

Comment 9

[Mounir Lamouri (:mounir)]

This patch sounds to work fine and fixes bug 616607 too. However, bug 616607 is a blocker so maybe the patch should move there if the review is slow?

Comment 10

[Dietrich Ayala (:dietrich)]

Making this blocking, since bug 616607 is dependent on it.

Comment 11

[Mounir Lamouri (:mounir)]

Neil added a new patch in bug 616607.

Comment 12

[Neil Deakin]

Fixed by bug 616607.

Comment 13

[George Carstoiu]

Build identifier: Mozilla/5.0 (X11; Linux i686; rv:2.0b10) Gecko/20100101 Firefox/4.0b10

Arrows not displayed in linux - see Screenshot 1.

Comment 14

[George Carstoiu]

Attachment: Screenshot 1

Comment 15

[Mounir Lamouri (:mounir)]

(In reply to comment #13)
> Build identifier: Mozilla/5.0 (X11; Linux i686; rv:2.0b10) Gecko/20100101
> Firefox/4.0b10
> 
> Arrows not displayed in linux - see Screenshot 1.

There is no arrow with GTK for the moment, see bug 604257.

Comment 16

[George Carstoiu]

Arrows in Linux where introduced as bug 604257 was fixed, but issue is still present. Go to Comment 12 from bug 604257.

Comment 17

[Steve Scott (pxbugz)]

Verified fixed in Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b12pre) Gecko/20110204 Firefox/4.0b12pre

Comment 18

[George Carstoiu]

Build identifier: Mozilla/5.0 (X11; Linux i686; rv:2.0b12pre) Gecko/20110206 Firefox/4.0b12pre

I can easily reproduce this issue with latest build also on Win7 and Mac OS X 10.6

STR:
 1. Go to http://channy.creation.net/project/firefox/geolocation.html and click on the "Click here" link below the map.
 2. View|Toolbars|Customization
 3. Drag and drop Awesome bar in the Add-on Bar (in the bottom part of the screen)
 4. Push the geolocation button and observe results (See Screenshot 1)

Observation:
 - once the drop-down arrow besides Share location is pushed, the arrow for the arrow panel is shown