616512 - partner repacks fail to upload if 'unsigned' directory doesn't exist yet

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[[e-mail] (:bhearsum)]

I hit this today during 3.6.13build3.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

For anyone else doing a double-take, you can hit this for non-windows partner builds because they complete faster than the vanilla win32 does.

Comment 2

[[e-mail] (:bhearsum)]

I think the best solution to this is to have unsigned platforms upload their partner repacks to 'partner-repacks', rather than 'unsigned/partner-repacks'. This will prevent an unnecessary re-upload to staging after signing.

Comment 3

[Chris Cooper [:coop] (he/him)]

(In reply to comment #2)
> I think the best solution to this is to have unsigned platforms upload their
> partner repacks to 'partner-repacks', rather than 'unsigned/partner-repacks'.
> This will prevent an unnecessary re-upload to staging after signing.

If we do this, please make sure the signing logic for partner repacks is verified/updated. We move partner repacks around a bit currently since we expect them under unsigned/.

Comment 4

[[e-mail] (:bhearsum)]

I'm digging around the partner scripts for bug 614227, I'll see if I can fix the rsyncs while I'm in there.

Comment 5

[[e-mail] (:bhearsum)]

Attachment: fix signing makefile to sign euballot builds properly

The rsync that pulls in partner repacks from "unsigned" needed adjusting. Tested this with 3.6.14.

Comment 6

[[e-mail] (:bhearsum)]

D'oh, this was supposed to go in bug 614227. Doesn't really matter since the patches from it fix this bug, too.

Comment 7

[[e-mail] (:bhearsum)]

After the next reconfig we'll be all done here

Comment 8

[[e-mail] (:bhearsum)]

Made it to production last week.