616544 - Fix try_parser to handle platforms that do not have talos available to them

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P1)

Description

[Lukas Blakk [:lsblakk] use ?needinfo]

Shawn reported that he did not get talos runs for this push and when I looked at the scheduler it turns out that the android-r7 platform being in the list has generated an error which means that the push gets the default set - no talos.

2010-12-03 10:03:23-0800 [HTTPPageGetter,client] Looking at the push json data for try comments
2010-12-03 10:03:23-0800 [HTTPPageGetter,client] TryChooser OPTIONS : MESSAGE Namespace(build=['opt'], do_everything=False, talos=['nochrome', 'dromaeo', 'chrome', 'dirty', 'cold'], test='none', user_platforms=['linux', 'linux64', 'macosx64', 'win32', 'android-r7']) : try: -b o -p linux,linux64,macosx64,win32,android-r7 -u none -t nochrome,dromaeo,chrome,dirty,cold
2010-12-03 10:03:23-0800 [HTTPPageGetter,client] Couldn't parse data: Requesting default try set. [Failure instance: Traceback: <type 'exceptions.KeyError'>: 'android-r7'
	/tools/buildbot-0.8.2/lib/python2.6/site-packages/twisted/web/client.py:175:handleResponse
	/tools/buildbot-0.8.2/lib/python2.6/site-packages/twisted/web/client.py:340:page
	/tools/buildbot-0.8.2/lib/python2.6/site-packages/twisted/internet/defer.py:318:callback
	/tools/buildbot-0.8.2/lib/python2.6/site-packages/twisted/internet/defer.py:424:_startRunCallbacks
	--- <exception caught here> ---
	/tools/buildbot-0.8.2/lib/python2.6/site-packages/twisted/internet/defer.py:441:_runCallbacks
	/tools/buildbotcustom-0.8.0/buildbotcustom/misc_scheduler.py:45:parseData
	/tools/buildbotcustom-0.8.0/buildbotcustom/try_parser.py:183:TryParser
	/tools/buildbotcustom-0.8.0/buildbotcustom/try_parser.py:97:getTestBuilders
	]
2010-12-03 10:03:23-0800 [HTTPPageGetter,client] No comments, passing empty string which will result in default set
2010-12-03 10:03:23-0800 [HTTPPageGetter,client] TryChooser OPTIONS : MESSAGE Namespace(build=['opt', 'debug'], do_everything=False, talos='none', test='all', user_platforms=['win64', 'macosx', 'macosx64', 'win32', 'linux64', 'linux', 'android']) :

Comment 1

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: Checks that platform is in prettyNames.keys() before trying to create talos builders in try_parser.py

Comment 2

[Chris Cooper [:coop] (he/him)]

Comment on attachment 495070 [details] [diff] [review]
Checks that platform is in prettyNames.keys() before trying to create talos builders in try_parser.py

Looks good.

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 495070 [details] [diff] [review]
Checks that platform is in prettyNames.keys() before trying to create talos builders in try_parser.py

http://hg.mozilla.org/build/buildbotcustom/rev/8fab7e00d552

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

landed and reconfig'd schedulers, try