616620 - Disable button won't work for add-ons that were just installed prior to restart

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Tobias (:Tobbi) Markus]

When you try to disable add-ons you just installed via the Search function, the Disable button won't work. No matter how many times you click it, it won't disable the add-on nor display any other message.

Steps to reproduce:
1. Go to Tools > Add-ons.
2. Search for any kind of add-on.
3. Install an add-on from the results list.
4. Click the Disable button.

Results:
Clicking the Disable button does nothing (not even display an error message) until Firefox has been restarted.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Right now this disable button is useless. There would be two options:

* Hide it so we don't expose an action which is not possible at this stage
* Make it work, so after the restart the extension is disabled

Comment 2

[Maniac Vlad Florin (:vladmaniac)]

It works if you insist with clicking 

Build ID: 

Mozilla/5.0 (Windows NT 6.1; rv:2.0b8pre) Gecko/20101213 Firefox/4.0b8pre

Comment 3

[Dave Townsend [:mossop] (PTO until Aug 21st)]

This is broken in a few ways. The API claims to support enabling/disabling of pending add-ons, trying to change that does take effect but sends no events to update the UI about it and doesn't save that change to disk so it gets lost anyway on restart.

It's unlikely that supporting disabling before restart is going to be terribly useful so the easiest fix is to just hide the disabled button from the UI.

Comment 4

[Dave Townsend [:mossop] (PTO until Aug 21st)]

Attachment: patch rev 1

This make it so uninstalled add-ons don't claim to be disablable thus hiding the button from the UI.

Comment 5

[Dave Townsend [:mossop] (PTO until Aug 21st)]

Landed: http://hg.mozilla.org/mozilla-central/rev/3844d838d24a

Comment 6

[Dave Townsend [:mossop] (PTO until Aug 21st)]

Actually landed in http://hg.mozilla.org/mozilla-central/rev/3844d838d24a

Comment 7

[Dave Townsend [:mossop] (PTO until Aug 21st)]

Ugh http://hg.mozilla.org/mozilla-central/rev/d48eb4e9d903

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b10pre) Gecko/20110119 Firefox/4.0b10pre