Closed
Bug 616620
Opened 15 years ago
Closed 15 years ago
Disable button won't work for add-ons that were just installed prior to restart
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
VERIFIED
FIXED
mozilla2.0b10
Tracking | Status | |
---|---|---|
blocking2.0 | --- | betaN+ |
People
(Reporter: Tobbi, Assigned: mossop)
Details
(Whiteboard: [AOMTestday])
Attachments
(1 file)
2.55 KB,
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
When you try to disable add-ons you just installed via the Search function, the Disable button won't work. No matter how many times you click it, it won't disable the add-on nor display any other message.
Steps to reproduce:
1. Go to Tools > Add-ons.
2. Search for any kind of add-on.
3. Install an add-on from the results list.
4. Click the Disable button.
Results:
Clicking the Disable button does nothing (not even display an error message) until Firefox has been restarted.
Comment 1•15 years ago
|
||
Right now this disable button is useless. There would be two options:
* Hide it so we don't expose an action which is not possible at this stage
* Make it work, so after the restart the extension is disabled
blocking2.0: --- → ?
Version: 1.9.2 Branch → Trunk
Assignee | ||
Updated•15 years ago
|
blocking2.0: ? → betaN+
Comment 2•15 years ago
|
||
It works if you insist with clicking
Build ID:
Mozilla/5.0 (Windows NT 6.1; rv:2.0b8pre) Gecko/20101213 Firefox/4.0b8pre
Assignee | ||
Updated•15 years ago
|
Assignee: nobody → dtownsend
Assignee | ||
Comment 3•15 years ago
|
||
This is broken in a few ways. The API claims to support enabling/disabling of pending add-ons, trying to change that does take effect but sends no events to update the UI about it and doesn't save that change to disk so it gets lost anyway on restart.
It's unlikely that supporting disabling before restart is going to be terribly useful so the easiest fix is to just hide the disabled button from the UI.
Assignee | ||
Updated•15 years ago
|
Whiteboard: [AOMTestday] → [AOMTestday][waiting on try]
Assignee | ||
Comment 4•15 years ago
|
||
This make it so uninstalled add-ons don't claim to be disablable thus hiding the button from the UI.
Attachment #502523 -
Flags: review?(robert.bugzilla)
Assignee | ||
Updated•15 years ago
|
Whiteboard: [AOMTestday][waiting on try] → [AOMTestday][has patch][needs review rs]
![]() |
||
Updated•15 years ago
|
Attachment #502523 -
Flags: review?(robert.bugzilla) → review+
![]() |
||
Updated•15 years ago
|
Whiteboard: [AOMTestday][has patch][needs review rs] → [AOMTestday][has patch]
Assignee | ||
Comment 5•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: in-testsuite+
Flags: in-litmus-
Resolution: --- → FIXED
Whiteboard: [AOMTestday][has patch] → [AOMTestday]
Target Milestone: --- → mozilla2.0b10
Assignee | ||
Comment 6•15 years ago
|
||
Actually landed in http://hg.mozilla.org/mozilla-central/rev/3844d838d24a
Assignee | ||
Comment 7•15 years ago
|
||
Comment 8•15 years ago
|
||
Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b10pre) Gecko/20110119 Firefox/4.0b10pre
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•