616629 - "Remember Password?" dialog shows too early

Status: RESOLVED DUPLICATE of bug 558178

(Toolkit :: Password Manager, defect)

Description

[Alex Limi (:limi) — Firefox UX Team]

With the notification bar, we asked whether to remember passwords when the page was actually loaded.

With the new doorhanger-style notifications, the question pops up immediately after you send the request to log in, and more importantly: before you know whether the login succeeded.

We should delay the remember password dialog until the page has actually rendered, so you know whether the password you entered was correct — so you don't store a bogus password just because the server was slow to respond.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

We didn't change when we show the notification (either bar or popup), so I don't think this is a regression.

Comment 2

[Alex Limi (:limi) — Firefox UX Team]

(In reply to comment #1)
> We didn't change when we show the notification (either bar or popup), so I
> don't think this is a regression.

Are you sure? I don't think I've ever seen the notification bar without there being at least some part of a page rendered below it. (Not arguing about the inclusion of the keyword, just curious :)

Comment 3

[:Margaret Leibovic]

I just tested this on 3.6, and Gavin is right.

I think waiting for the page to render would be a challenge, since there are often redirects when authenticating, so it would be tough to know which page we want to wait for. We could just introduce a time delay, but that seems like it could just make Firefox seem slower.

Comment 4

[Michal 'hramrach' Suchanek]

I think this is just a timer in 3.6, there is some slide-in effect.

Maybe the popup only shows after some page with content shows (eg not error or redirect, which is already another bug).

Comment 5

[Samuel Bronson]

Er, um, has this bug been forgotten?

(I hope I'm not terribly annoying the 7 people on CC.)