Closed Bug 616633 Opened 14 years ago Closed 14 years ago

Context menu contains 'Disable' item for already disabled extensions and plugins

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla2.0b10
Tracking Flags:
Tracking Status
blocking2.0 --- final+

People

(Reporter: Tobbi, Assigned: Unfocused)

Details

(Whiteboard: [AOMTestday][softblocker])

Attachments

(1 file)

Patch v1
3.44 KB, patch
mossop
: review+
Details | Diff | Splinter Review 
When disabling an add-on (plugin or extension) via the context menu, (right-click it and select "Disable"), then right-clicking again, you can find that it still says 'Disable' in the context menu.

Clicking 'Disable' again does nothing.

Solution: Show 'Enable' menu item in context menu for already disabled extensions and plugins.
It looks like the context menu only changes when you select another panel and go back to the original one. Then you can see the correct item. 

This affects 'Enable' as well (depending on the state)
It changes if you select a different add-on in the list too.

Need to update the commands after any add-on changes state.
blocking2.0: --- → final+
Assignee: nobody → ddahl
Assignee: ddahl → nobody
Assignee: nobody → bmcbride
Status: NEW → ASSIGNED
Attached patch Patch v1 — — Splinter Review 

        Attachment #502607 -
        Flags: review?(dtownsend)
Whiteboard: [AOMTestday] → [AOMTestday][has patch][needs review Mossop]
Whiteboard: [AOMTestday][has patch][needs review Mossop] → [AOMTestday][has patch][needs review Mossop][soft blocker]

        Attachment #502607 -
        Flags: review?(dtownsend) → review+
Whiteboard: [AOMTestday][has patch][needs review Mossop][soft blocker] → [AOMTestday][has patch][soft blocker]

    
    

    
  
Landed: https://hg.mozilla.org/mozilla-central/rev/6e04a051a8da

Automated tests cover this well.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Flags: in-litmus-
Resolution: --- → FIXED
Whiteboard: [AOMTestday][has patch][soft blocker] → [AOMTestday][soft blocker]
Target Milestone: --- → mozilla2.0b10
Whiteboard: [AOMTestday][soft blocker] → [AOMTestday][softblocker]

    
    

    
  
Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b10pre) Gecko/20110112 Firefox/4.0b10pre ID:20110112033217
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: