Context menu contains 'Disable' item for already disabled extensions and plugins

VERIFIED FIXED in mozilla2.0b10

Status

()

Toolkit
Add-ons Manager
VERIFIED FIXED
7 years ago
6 years ago

People

(Reporter: Tobbi, Assigned: Unfocused)

Tracking

Trunk
mozilla2.0b10
Points:
---
Bug Flags:
in-testsuite +
in-litmus -

Firefox Tracking Flags

(blocking2.0 final+)

Details

(Whiteboard: [AOMTestday][softblocker])

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
When disabling an add-on (plugin or extension) via the context menu, (right-click it and select "Disable"), then right-clicking again, you can find that it still says 'Disable' in the context menu.

Clicking 'Disable' again does nothing.

Solution: Show 'Enable' menu item in context menu for already disabled extensions and plugins.
(Reporter)

Comment 1

7 years ago
It looks like the context menu only changes when you select another panel and go back to the original one. Then you can see the correct item. 

This affects 'Enable' as well (depending on the state)
It changes if you select a different add-on in the list too.

Need to update the commands after any add-on changes state.
blocking2.0: --- → final+
Assignee: nobody → ddahl
Assignee: ddahl → nobody
Assignee: nobody → bmcbride
Status: NEW → ASSIGNED
Created attachment 502607 [details] [diff] [review]
Patch v1
Attachment #502607 - Flags: review?(dtownsend)
Whiteboard: [AOMTestday] → [AOMTestday][has patch][needs review Mossop]
Whiteboard: [AOMTestday][has patch][needs review Mossop] → [AOMTestday][has patch][needs review Mossop][soft blocker]
Attachment #502607 - Flags: review?(dtownsend) → review+
Whiteboard: [AOMTestday][has patch][needs review Mossop][soft blocker] → [AOMTestday][has patch][soft blocker]
Landed: https://hg.mozilla.org/mozilla-central/rev/6e04a051a8da

Automated tests cover this well.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Flags: in-testsuite+
Flags: in-litmus-
Resolution: --- → FIXED
Whiteboard: [AOMTestday][has patch][soft blocker] → [AOMTestday][soft blocker]
Target Milestone: --- → mozilla2.0b10
Whiteboard: [AOMTestday][soft blocker] → [AOMTestday][softblocker]
Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b10pre) Gecko/20110112 Firefox/4.0b10pre ID:20110112033217
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.