Clean up app button styling in browser-aero.css

RESOLVED FIXED in Firefox 4.0b8

Status

()

Firefox
Theme
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
Firefox 4.0b8
All
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

8 years ago
Created attachment 495239 [details] [diff] [review]
patch

From bug 606160 comment 33:

> Note that windows-compositor doesn't imply windows-default-theme and the
> negative margin actually needs both, since we set the extra border only for
> windows-default-theme. A better solution might be to change the border to be
> added for everything but windows-classic in browser-aero.css:
> 
> @media not all and (-moz-windows-classic) {
>   #appmenu-button {
>     border: ...
>     margin-bottom: 1px; /* compensate white outer border */
>   }
> }
> 
> @media all and (-moz-windows-compositor) {
>   #appmenu-button {
>     margin-bottom: -1px; /* compensate white outer border */
>   }
> }

The attached patch does that.
Attachment #495239 - Flags: review?(gavin.sharp)
(Assignee)

Comment 1

8 years ago
Created attachment 495473 [details] [diff] [review]
patch

updated to tip
Attachment #495239 - Attachment is obsolete: true
Attachment #495473 - Flags: review?(gavin.sharp)
Attachment #495239 - Flags: review?(gavin.sharp)
(Assignee)

Updated

8 years ago
Attachment #495473 - Flags: review?(jmathies)
Comment on attachment 495473 [details] [diff] [review]
patch

rs=me...
Attachment #495473 - Flags: review?(gavin.sharp) → review+
(Assignee)

Updated

8 years ago
Attachment #495473 - Flags: review?(jmathies) → approval2.0?
Attachment #495473 - Flags: approval2.0? → approval2.0+
(Assignee)

Comment 3

8 years ago
http://hg.mozilla.org/mozilla-central/rev/19721341c737
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b8
You need to log in before you can comment on or make changes to this bug.