616714 - Bug 603367 breaks non-libxul builds

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(no longer active)]

In this revision:

http://hg.mozilla.org/mozilla-central/rev/3bb7e1a3cb22

USE_ANGLE is set in content/canvas/src/Makefile.in, which triggers http://hg.mozilla.org/mozilla-central/file/3bb7e1a3cb22/content/canvas/src/Makefile.in#l93, which is not needed, because layout/build/Makefile.in takes care of it.  Currently, non-libxul builds are broken because of it.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/445e8a8d79b2

Comment 3

[Damon Sicore (:damons)]

We're in the endgame of Firefox 4, and it's really important that we only work on blockers.  Maybe this should have been a blocker?  If not, let's make sure we stay focused on blocking bugs!

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Not being able to build Firefox probably impedes fixing those blockers ;-)

Comment 5

[(no longer active)]

(In reply to comment #3)
> We're in the endgame of Firefox 4, and it's really important that we only work
> on blockers.  Maybe this should have been a blocker?  If not, let's make sure
> we stay focused on blocking bugs!

Totally agreed.  This particular case was basically preventing me and the rest of the developers who build Firefox with libxul disabled from working on anything though.  :-)

Comment 6

[(not currently active) Ted Mielczarek]

I think there's a class of bugs like this that perhaps ostensibly should be blocking, since they're blocking developers from getting useful work done, but can be fixed so quickly (4 hours from filing to landing the fix) that the blocker nomination process is just too heavyweight. I don't think it makes sense to spend much time worrying about them either way, given how simple they are.