warning: Several warnings while trying to build gfx/cairo/libpixman including 'extern', '-Wsign-compare', '-pedantic'

RESOLVED WONTFIX

Status

()

Core
Graphics
RESOLVED WONTFIX
7 years ago
2 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

(Blocks: 1 bug)

Trunk
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning])

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
In file included from gfx/cairo/libpixman/src/pixman-region16.c:49:
gfx/cairo/libpixman/src/pixman-region.c:
2044: warning: ‘extern’ is not at beginning of declaration
2107: warning: ‘extern’ is not at beginning of declaration
In file included from gfx/cairo/libpixman/src/pixman-region32.c:47:
gfx/cairo/libpixman/src/pixman-region.c:
2044: warning: ‘extern’ is not at beginning of declaration
2107: warning: ‘extern’ is not at beginning of declaration
(Assignee)

Comment 1

7 years ago
Created attachment 495343 [details] [diff] [review]
patch
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #495343 - Flags: review?(jmuizelaar)

Updated

7 years ago
Whiteboard: [build_warning]

Updated

7 years ago
Blocks: 187528

Comment 2

6 years ago
Corresponding upstream bug is https://bugs.freedesktop.org/show_bug.cgi?id=42634

Moreover there are several warning apart from 'extern' ones. Pasting them below:

pixman-combine.c.template: In function ‘combine_mask_ca’:
pixman-combine.c.template:29:11: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
pixman-combine.c.template: In function ‘combine_mask_value_ca’:
pixman-combine.c.template:58:11: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
pixman-combine.c.template: In function ‘combine_mask_alpha_ca’:
pixman-combine.c.template:79:11: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
pixman-combine.c.template: In function ‘combine_in_reverse_ca’:
pixman-combine.c.template:1726:8: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
pixman-combine.c.template: In function ‘combine_out_reverse_ca’:
pixman-combine.c.template:1791:8: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
pixman-combine.c.template: In function ‘combine_mask_ca’:
pixman-combine.c.template:29:11: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
pixman-combine.c.template: In function ‘combine_mask_value_ca’:
pixman-combine.c.template:58:11: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
pixman-combine.c.template: In function ‘combine_mask_alpha_ca’:
pixman-combine.c.template:79:11: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
pixman-combine.c.template: In function ‘combine_in_reverse_ca’:
pixman-combine.c.template:1726:8: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
pixman-combine.c.template: In function ‘combine_out_reverse_ca’:
pixman-combine.c.template:1791:8: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
In file included from /mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-region16.c:49:0:
/mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-region.c:2044:1: warning: ‘extern’ is not at beginning of declaration [-Wold-style-declaration]
In file included from /mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-region16.c:49:0:
/mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-region.c:2107:1: warning: ‘extern’ is not at beginning of declaration [-Wold-style-declaration]
In file included from /mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-region32.c:47:0:
/mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-region.c:2044:1: warning: ‘extern’ is not at beginning of declaration [-Wold-style-declaration]
In file included from /mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-region32.c:47:0:
/mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-region.c:2107:1: warning: ‘extern’ is not at beginning of declaration [-Wold-style-declaration]
/mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-mmx.c:113:5: warning: ISO C90 forbids specifying subobject to initialize [-pedantic]
/mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-mmx.c:114:5: warning: ISO C90 forbids specifying subobject to initialize [-pedantic]
/mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-mmx.c:115:5: warning: ISO C90 forbids specifying subobject to initialize [-pedantic]
/mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-mmx.c:116:5: warning: ISO C90 forbids specifying subobject to initialize [-pedantic]
/mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-mmx.c:117:5: warning: ISO C90 forbids specifying subobject to initialize [-pedantic]
/mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-mmx.c:118:5: warning: ISO C90 forbids specifying subobject to initialize [-pedantic]
/mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-mmx.c:119:5: warning: ISO C90 forbids specifying subobject to initialize [-pedantic]
/mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-mmx.c:120:5: warning: ISO C90 forbids specifying subobject to initialize [-pedantic]
/mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-mmx.c:121:5: warning: ISO C90 forbids specifying subobject to initialize [-pedantic]
/mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-mmx.c:122:5: warning: ISO C90 forbids specifying subobject to initialize [-pedantic]
/mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-mmx.c:123:5: warning: ISO C90 forbids specifying subobject to initialize [-pedantic]
/mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-mmx.c:124:5: warning: ISO C90 forbids specifying subobject to initialize [-pedantic]
/mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-mmx.c:125:5: warning: ISO C90 forbids specifying subobject to initialize [-pedantic]
/mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-mmx.c:126:5: warning: ISO C90 forbids specifying subobject to initialize [-pedantic]
/mozilla/mozilla-central/gfx/cairo/libpixman/src/pixman-mmx.c:127:5: warning: ISO C90 forbids specifying subobject to initialize [-pedantic]

Updated

6 years ago
Summary: warning: extern is not at beginning of declaration in <return_type_t> PIXMAN_EXPORT PREFIX (<stuff>) → warning: Several warnings while trying to build gfx/cairo/libpixman including 'extern', '-Wsign-compare', '-pedantic'
Comment on attachment 495343 [details] [diff] [review]
patch

This should be submitted upstream
Attachment #495343 - Flags: review?(jmuizelaar) → review-
Fixes for warnings in third-party code should be submitted upstream, not patched in mozilla-central.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.