Closed Bug 616810 Opened 13 years ago Closed 13 years ago

CRs in cl.py generatesnippet.py buildlist.py upload.py util.py implicit.py

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

Details

Attachments

(1 file)

Proposed patch
57.50 KB, patch
khuey
: review+
benjamin
: approval2.0+
Details | Diff | Splinter Review 
cl.py: 96 lines, 95 CRs
generatesnippet.py: 198 lines, 198 CRs
buildlist.py: 73 lines, 73 CRs
upload.py: 227 lines, 227 CRs
util.py: 50 lines, 50 CRs
implicit.py: 13 lines, 13 CRs
Attached patch Proposed patch — — Splinter Review 
Assignee: nobody → neil
Status: NEW → ASSIGNED

        Attachment #495360 -
        Flags: review?(khuey)

    
  

        Attachment #495360 -
        Flags: approval2.0?

    
    

    
  
I don't think this qualifies as needing approval and can just land as NPOTB/COMMENT-ONLY

    
  

        Attachment #495360 -
        Flags: approval2.0? → approval2.0+

    
    

    
  
Pushed changeset 142d984cce44 to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED

    
  
Product: Core → Firefox Build System

          You need to log in
          before you can comment on or make changes to this bug.