616881 - Download Tracker is not functioning

Status: RESOLVED FIXED

(Websites Graveyard :: firefoxlive.mozilla.org, defect)

Description

[J. Jason Smith]

User-Agent:       Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b7) Gecko/20100101 Firefox/4.0b7
Build Identifier: 

The download tracker is not functioning. People are noticing that the percentage doesn't change and that they are not any closer to helping the cubs, which is part of the draw to the site. 

Reproducible: Always

Steps to Reproduce:
Visit the site.

Comment 1

[Michael Morgan [:morgamic]]

If we are tracking by IP it might just be tracking the load balancer IP behind Zeus and not the remote IP.

Comment 2

[John Slater]

We'll regroup tomorrow morning and assess what needs to be done - this will definitely be one of the top priorities. Even on Friday we were seeing news reports that the site was stuck at 56%, so if it's now stuck at 23% for long people will begin to think something is up.

Given that we're really tracking 3 different things (non-Firefox users clicking on the download 3.6 button, Firefox 3.6 and below users clicking on the download Fx4 beta button, and Fx4 beta users clicking on the tell a friend button) I'd be fine simply tracking the # of clicks. If there are other ways I'm certainly open, but the main thing is going the simplest route that gets this working.

Comment 3

[John Slater]

A few further thoughts on this...

We should use this opportunity to reset the download counter at 0 and move on to the next treat. We can say that they've already earned the jungle gym (are currently in the process of getting that sent to the zoo) and can add some messaging about what the next treat is. I'll post that here soon.

In the meantime, this is the top priority of things to fix today. Rafael/Sebastian, do you want to have a call to discuss?

Comment 4

[Michael Morgan [:morgamic]]

I'm having a hard time tracking where currentDownloads comes from.

The general idea is that we need to make sure we're filtering on IP and pooling results -- if both of those are happening properly, we should be in good shape.

In the wp-polls plugin we already have something similar:

### Function: Get IP Address
if(!function_exists('get_ipaddress')) {
    function get_ipaddress() {
        if (empty($_SERVER["HTTP_X_FORWARDED_FOR"])) {
            $ip_address = $_SERVER["REMOTE_ADDR"];
        } else {
            $ip_address = $_SERVER["HTTP_X_FORWARDED_FOR"];
        }    
        if(strpos($ip_address, ',') !== false) {
            $ip_address = explode(',', $ip_address);
            $ip_address = $ip_address[0];
        }    
        return esc_attr($ip_address);
    }    
}

Looks like this data is coming /javascript/data_downloads.json, but from what I can tell, however, nothing is updating that file... ?  So are we supposed to be tracking site metrics and updating data_downloads.json manually?

Comment 5

[John Slater]

Here's some text to replace the "Next special treat: a jungle gym!" copy:

You've already earned a jungle gym for the cubs. Next: yummy treats!

Or, if that's too long, we can just go with:
Next special treat: yummy snacks!

(But I'd prefer the former if possible.)

Comment 6

[John Slater]

Slight copy change to comment #5 based on input from the Knoxville Zoo:

You've already earned a jungle gym for the cubs. Next: grass flats!

Or, if that's too long, we can just go with:
Next special treat: grass flats!

(But I'd prefer the former if possible.)

Comment 7

[Mike Alexis [:malexis]]

copy has been updated. 

morgamic and I will figure out how to manage the download tracker updates.

Seems to be working but checked this morning and it's still at 3%. 

keeping this open.

Comment 8

[Mike Alexis [:malexis]]

One more copy change:

the header on the download tracker for Fx4 beta users reads: "Download for Treats"

Copy should read: "Earn Treats for the Cubs"

Comment 9

[J. Jason Smith]

Any updates on this thread? Download is still static at 3%.

Comment 10

[Michael Morgan [:morgamic]]

As far as I can tell, it's not even dynamic.  It reads from a static JSON file that doesn't get updated -- either that or I'm not seeing where the JSON gets updated from.

Comment 11

[John Slater]

Does that mean we'll have to push a change every day? That seems like a pretty high pain-in-the-ass factor for WebDev, QA & IT.

Comment 12

[William Reynolds [:williamr]]

Could the reward copy and the goal percentage be updated through WordPress as variables / post meta data? Requires some webdev changes upfront but no ongoing work for the three teams.

Comment 13

[Michael Morgan [:morgamic]]

Yeah -- we'd have to remove the call to setDownloads and instead inject it into the download post so we can update it whenever we need to.

Comment 14

[Michael Morgan [:morgamic]]

Since the main js file is included in the footer, we'll have to:
- move firefox_live-min.js prior to the content pane
- probably remove data_downloads.json (it is called "data_dowloads.json" in SVN!)
- add a conditional to check if currentDownloads is typof == 'undefined' and set a default progress if so
- otherwise, call setDownloads([#####]) inside a script tag as a part of the downloads post

Comment 15

[Michael Morgan [:morgamic]]

Attachment: moves jquery and site js to head section, removes json

This moves the site js and jquery to the header, which allows us to call setDownloads in the download post (wp post content).  It will allow us to update it whenever we want via content edits.

Comment 16

[Michael Morgan [:morgamic]]

Code to put in content:

<script type="text/javascript">
setDownloads([######]);
</script>

Comment 17

[Michael Morgan [:morgamic]]

r79057; need to inject the code from comment #16 into stage to verify.

Comment 18

[J. Jason Smith]

Still stuck at 37%.

Comment 19

[J. Jason Smith]

Can we at least manually adjust this number higher today?

Comment 20

[Stephen Donner [:stephend] Not actively reading bugmail]

Reopening until someone does comment 16, so I/Raymond/others can verify on staging.

Comment 21

[Michael Morgan [:morgamic]]

Anybody can update this in wordpress.  Edit the download post.

Like I said before it's not dynamic because the work wasn't actually done to log and retrieve download data.  Since nobody caught this prior to launch, we can either manually update on an agreed schedule or have a dev put in 1-2 days of developmentto fix this in January.
Their work

Comment 22

[Michael Morgan [:morgamic]]

If you edit, only edit in HTML mode.

Comment 23

[Mike Alexis [:malexis]]

I updated the download tracker to 62% (I thought that was a reasonable number) and the change is live.

Comment 24

[Stephen Donner [:stephend] Not actively reading bugmail]

Currently broken in staging due to bug 618915, likely (not that it matters anyway).

Comment 25

[J. Jason Smith]

Team - if we're going to manually update this number it needs to happen once a day, if not twice. The number not changing is a huge perception problem - is this possible?

Comment 26

[John Slater]

It's not an ideal solution, but it looks like this is something we'll have to push manually a couple of times a week.

Fwiw, we're resetting the counter and announcing a new treat target tonight.