Closed
Bug 616900
Opened 14 years ago
Closed 14 years ago
Convert selection events to style described in bug 593921
Categories
(Add-on SDK Graveyard :: General, defect)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
1.0b1
People
(Reporter: adw, Assigned: adw)
References
Details
(Whiteboard: [cherry-pick-1.0b1])
Attachments
(1 file)
|
2.46 KB,
patch
|
myk
:
review+
|
Details | Diff | Splinter Review |
See bug 593921 comment 8. All the select event tests are commented out, but I tested manually that the patch works, and that `this` and event.emitter are correct.
Attachment #495422 -
Flags: review?(myk)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 495422 [details] [diff] [review] patch (In reply to comment #0) > All the select event tests are commented out Gack. :-/ > but I tested manually that the > patch works, and that `this` and event.emitter are correct. Cool! r=myk
Attachment #495422 -
Flags: review?(myk) → review+
|
Assignee | |
Comment 2•14 years ago
|
||
https://github.com/mozilla/addon-sdk/commit/68b79eeed081b4409e6219df0259759a3e22ec50
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [cherry-pick-needed]
Target Milestone: -- → 1.0b1
|
|
||
Comment 3•14 years ago
|
||
https://github.com/mozilla/addon-sdk/commit/acb50bf385970f66a8648b8aa4f62cd857cd8e87
Whiteboard: [cherry-pick-needed] → [cherry-pick-1.0b1]
You need to log in
before you can comment on or make changes to this bug.
Description
•