Closed
Bug 616918
Opened 14 years ago
Closed 13 years ago
Turn on ANGLE on Win64
Categories
(Core :: Graphics: CanvasWebGL, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: m_kato, Assigned: m_kato)
References
Details
Attachments
(2 files, 1 obsolete file)
21.50 KB,
patch
|
bjacob
:
review+
|
Details | Diff | Splinter Review |
24.36 KB,
patch
|
bjacob
:
review+
|
Details | Diff | Splinter Review |
http://code.google.com/p/angleproject/issues/detail?id=55 and some fixes
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → m_kato
Currently: Adapter Description: NVIDIA GeForce 9500GS Vendor ID: 10de Device ID: 0644 Adapter RAM: 512 Adapter Drivers: nvd3dumx,nvwgf2umx,nvwgf2umx nvd3dum,nvwgf2um,nvwgf2um Driver Version:8.17.12.6099 Driver Date: 10-16-2010 Direct2D Enabled: true DirectWrite Enabled: true GPU Accelerated Windows: 1/1 Direct3D 10
Assignee | ||
Comment 3•13 years ago
|
||
Attachment #495441 -
Attachment is obsolete: true
Assignee | ||
Updated•13 years ago
|
Attachment #537974 -
Flags: review?(bjacob)
Comment 4•13 years ago
|
||
Comment on attachment 537974 [details] [diff] [review] fix v2 r=me with the following reservation: +ifeq ($(OS_TEST),x86_64) +DXLIB_ARCH=x64 +else +DXLIB_ARCH=x86 +endif We're not interested about whether the _OS_ is 64bit, but rather about whether the application is. What does OS_TEST really mean? If it really means the OS then it's not what you want here. Since this requires changes inside of ANGLE itself, could you please get this part of your patch reviewed upstream? http://code.google.com/p/angleproject/issues/list They'll be more competent than me to review changes in ANGLE itself.
Attachment #537974 -
Flags: review?(bjacob) → review+
Assignee | ||
Comment 5•13 years ago
|
||
(In reply to comment #4) > Since this requires changes inside of ANGLE itself, could you please get > this part of your patch reviewed upstream? > http://code.google.com/p/angleproject/issues/list > They'll be more competent than me to review changes in ANGLE itself. Although I already filed as Issue 55 (http://code.google.com/p/angleproject/issues/detail?id=55), it is no answer about reviewing. Benoit, Do you know a review process of ANGLE? (Via Gerrit?) I cannot found a document for it.
Comment 6•13 years ago
|
||
I don't know anything else than attaching patches and pinging them. Try emailing Nicolas and Daniel; also I'm CCing Daniel here.
Comment 7•13 years ago
|
||
I didn't realize this was a blocker for you. Can you make sure the patches on Issue 55 are up to date for current top-of-tree, and detail what sort of testing has been done with the 64-bit build?
Comment 8•13 years ago
|
||
(In reply to comment #4) > Comment on attachment 537974 [details] [diff] [review] [review] > fix v2 > > r=me with the following reservation: > > +ifeq ($(OS_TEST),x86_64) > +DXLIB_ARCH=x64 > +else > +DXLIB_ARCH=x86 > +endif Oh, I just remembered that we already have a variable for this in our build system: MOZ_DIRECTX_SDK_CPU_SUFFIX
Comment 9•13 years ago
|
||
Updated patches from Issue #55 have been checked in (ANGLE r698)
Comment 10•13 years ago
|
||
Thanks a lot.
Assignee | ||
Comment 11•13 years ago
|
||
I need 1 more fix to pass mochitest-1. I filed as issue 190.
Assignee | ||
Comment 12•13 years ago
|
||
Daniel, could you review http://code.google.com/p/angleproject/issues/detail?id=190 ? A patch is attached into that bug.
Comment 13•13 years ago
|
||
checked in as ANGLE r707
Comment 14•13 years ago
|
||
Thanks for the heads up. Will sync our ANGLE copy soon.
Assignee | ||
Comment 15•13 years ago
|
||
Assignee | ||
Updated•13 years ago
|
Attachment #550620 -
Flags: review?(bjacob)
Comment 16•13 years ago
|
||
Comment on attachment 550620 [details] [diff] [review] fix v3 Excellent! Thanks for keeping our ANGLE patchset clean too.
Attachment #550620 -
Flags: review?(bjacob) → review+
Assignee | ||
Comment 17•13 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/8628c51e497c
Whiteboard: [inbound]
Comment 18•13 years ago
|
||
Merged: http://hg.mozilla.org/mozilla-central/rev/8628c51e497c
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
You need to log in
before you can comment on or make changes to this bug.
Description
•