Status

()

Core
Canvas: WebGL
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

(Blocks: 1 bug)

Trunk
x86_64
Windows Vista
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Created attachment 495441 [details] [diff] [review]
fix v1

http://code.google.com/p/angleproject/issues/detail?id=55 and some fixes
(Assignee)

Updated

7 years ago
Assignee: nobody → m_kato
Duplicate of this bug: 621007

Comment 2

6 years ago
Currently:     
      
        
Adapter Description: NVIDIA GeForce 9500GS
Vendor ID: 10de
Device ID: 0644
Adapter RAM: 512
Adapter Drivers: nvd3dumx,nvwgf2umx,nvwgf2umx nvd3dum,nvwgf2um,nvwgf2um
Driver Version:8.17.12.6099
Driver Date: 10-16-2010
Direct2D Enabled: true
DirectWrite Enabled: true
GPU Accelerated Windows: 1/1 Direct3D 10
(Assignee)

Comment 3

6 years ago
Created attachment 537974 [details] [diff] [review]
fix v2
Attachment #495441 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Attachment #537974 - Flags: review?(bjacob)
Comment on attachment 537974 [details] [diff] [review]
fix v2

r=me with the following reservation:

+ifeq ($(OS_TEST),x86_64)
+DXLIB_ARCH=x64
+else
+DXLIB_ARCH=x86
+endif

We're not interested about whether the _OS_ is 64bit, but rather about whether the application is. What does OS_TEST really mean? If it really means the OS then it's not what you want here.

Since this requires changes inside of ANGLE itself, could you please get this part of your patch reviewed upstream?
http://code.google.com/p/angleproject/issues/list
They'll  be more competent than me to review changes in ANGLE itself.
Attachment #537974 - Flags: review?(bjacob) → review+
(Assignee)

Comment 5

6 years ago
(In reply to comment #4)
> Since this requires changes inside of ANGLE itself, could you please get
> this part of your patch reviewed upstream?
> http://code.google.com/p/angleproject/issues/list
> They'll  be more competent than me to review changes in ANGLE itself.

Although I already filed as Issue 55 (http://code.google.com/p/angleproject/issues/detail?id=55), it is no answer about reviewing.

Benoit, Do you know a review process of ANGLE?  (Via Gerrit?)  I cannot found a document for it.
I don't know anything else than attaching patches and pinging them. Try emailing Nicolas and Daniel; also I'm CCing Daniel here.

Comment 7

6 years ago
I didn't realize this was a blocker for you.  Can you make sure the patches on Issue 55 are up to date for current top-of-tree, and detail what sort of testing has been done with the 64-bit build?
(In reply to comment #4)
> Comment on attachment 537974 [details] [diff] [review] [review]
> fix v2
> 
> r=me with the following reservation:
> 
> +ifeq ($(OS_TEST),x86_64)
> +DXLIB_ARCH=x64
> +else
> +DXLIB_ARCH=x86
> +endif

Oh, I just remembered that we already have a variable for this in our build system: MOZ_DIRECTX_SDK_CPU_SUFFIX

Comment 9

6 years ago
Updated patches from Issue #55 have been checked in (ANGLE r698)
Thanks a lot.
(Assignee)

Updated

6 years ago
Blocks: 671567
(Assignee)

Comment 11

6 years ago
I need 1 more fix to pass mochitest-1.  I filed as issue 190.
(Assignee)

Comment 12

6 years ago
Daniel, could you review http://code.google.com/p/angleproject/issues/detail?id=190 ?  A patch is attached into that bug.

Comment 13

6 years ago
checked in as ANGLE r707
Thanks for the heads up. Will sync our ANGLE copy soon.
(Assignee)

Comment 15

6 years ago
Created attachment 550620 [details] [diff] [review]
fix v3
(Assignee)

Updated

6 years ago
Attachment #550620 - Flags: review?(bjacob)
Comment on attachment 550620 [details] [diff] [review]
fix v3

Excellent! Thanks for keeping our ANGLE patchset clean too.
Attachment #550620 - Flags: review?(bjacob) → review+
(Assignee)

Comment 17

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/8628c51e497c
Whiteboard: [inbound]
Merged:
http://hg.mozilla.org/mozilla-central/rev/8628c51e497c
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
You need to log in before you can comment on or make changes to this bug.