Created attachment 495441 [details] [diff] [review]
http://code.google.com/p/angleproject/issues/detail?id=55 and some fixes
*** Bug 621007 has been marked as a duplicate of this bug. ***
Adapter Description: NVIDIA GeForce 9500GS
Vendor ID: 10de
Device ID: 0644
Adapter RAM: 512
Adapter Drivers: nvd3dumx,nvwgf2umx,nvwgf2umx nvd3dum,nvwgf2um,nvwgf2um
Driver Date: 10-16-2010
Direct2D Enabled: true
DirectWrite Enabled: true
GPU Accelerated Windows: 1/1 Direct3D 10
Created attachment 537974 [details] [diff] [review]
Comment on attachment 537974 [details] [diff] [review]
r=me with the following reservation:
We're not interested about whether the _OS_ is 64bit, but rather about whether the application is. What does OS_TEST really mean? If it really means the OS then it's not what you want here.
Since this requires changes inside of ANGLE itself, could you please get this part of your patch reviewed upstream?
They'll be more competent than me to review changes in ANGLE itself.
(In reply to comment #4)
> Since this requires changes inside of ANGLE itself, could you please get
> this part of your patch reviewed upstream?
> They'll be more competent than me to review changes in ANGLE itself.
Although I already filed as Issue 55 (http://code.google.com/p/angleproject/issues/detail?id=55), it is no answer about reviewing.
Benoit, Do you know a review process of ANGLE? (Via Gerrit?) I cannot found a document for it.
I don't know anything else than attaching patches and pinging them. Try emailing Nicolas and Daniel; also I'm CCing Daniel here.
I didn't realize this was a blocker for you. Can you make sure the patches on Issue 55 are up to date for current top-of-tree, and detail what sort of testing has been done with the 64-bit build?
(In reply to comment #4)
> Comment on attachment 537974 [details] [diff] [review] [review]
> fix v2
> r=me with the following reservation:
> +ifeq ($(OS_TEST),x86_64)
Oh, I just remembered that we already have a variable for this in our build system: MOZ_DIRECTX_SDK_CPU_SUFFIX
Updated patches from Issue #55 have been checked in (ANGLE r698)
Thanks a lot.
I need 1 more fix to pass mochitest-1. I filed as issue 190.
Daniel, could you review http://code.google.com/p/angleproject/issues/detail?id=190 ? A patch is attached into that bug.
checked in as ANGLE r707
Thanks for the heads up. Will sync our ANGLE copy soon.
Created attachment 550620 [details] [diff] [review]
Comment on attachment 550620 [details] [diff] [review]
Excellent! Thanks for keeping our ANGLE patchset clean too.