61692 - nsIEventQueueService not IDLified

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement, P3)

Description

[Dan Mosedale (:dmosedale, :dmose)]

Creating proxy events from JavaScript requires handing an eventqueue to the
proxy manager.  So JS needs to be able to queuy the event queue service for
event queues.  I'm almost done with nsIEventQueue.idl and nsIEventQueueService.idl.

Comment 1

[Doug Turner (:dougt)]

Could you also add a "ResolveEventQueue"-like function which will take a enum
instead of an event queue and return the appropriate eventQ?  how does
|resolveEventQueueByEnum| sound?

The two enums would be either the current thread's event queue or the UI
thread's event queue.  

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Heh, after talking to jband and brendan, I came to the same conclusion earlier
this evening.  Should be straightforward; diffs coming soon to a bug near you.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: patch to IDLify nsIEventQueue & nsIEventQueueService

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

I just took copies of the .h files and edited them until they were IDL.  Added a
nsIEventQueue::getSpecialEventQueue() which is a scriptable method to get either
the current thread or UI thread's event queue.  Peter, this should allow you to
create a proxy object for calling back to the UI thread from JS, I think.  Can
you give it a shot and let me know if there's still stuff missing?

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Patch v2, after input from /be.

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Patch v3; last try had bogus trailing #endif

Comment 7

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: patch v4; last rev forgot to tweak MANIFEST and MANIFEST_IDL

Comment 8

[John Bandhauer]

r=jband. Looks OK to me. You have to update the Mac project too right?

Comment 9

[Brendan Eich [:brendan]]

sr=[e-mail] -- don't toast the Mac!  I think dmose is triple-thread
(Mac, Win, and Linux machines on his desk) so I have faith.

nsIEventQueue.idl could use some doc-comments, but since nsIEventQueue.h, which
it is replacing, had none, we can fix this lack in a later step.  File a bug?

/be

Comment 10

[Peter Van der Beken]

Works out fine for me, i had to clobber mozilla/xpcom. I can now create proxies
from JS, just have to make sure to use PROXY_SYNC. I can't help with testing on
anything other than WinNT, my home machine (Mac) is about 300km away :-(.

Comment 11

[Dan Mosedale (:dmosedale, :dmose)]

Fix checked in on all three platforms last week; marking FIXED.

Brendan: bug 62604 about doxygen comments filed.

Peter: In a conversation with dougt, he said that PROXY_ASYNC should work from
JS as well.  If you're seeing problems with it, can you file a bug against him
and CC me on it?  Thanks.