"Error: getSelectedItem is not defined" when switching from jsObject viewer to dom viewer in document pane

RESOLVED FIXED

Status

Other Applications
DOM Inspector
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: crussell, Assigned: crussell)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

1. Open the DOM Inspector
2. Inspect some document
3. Switch to the JavaScript Object viewer in the document pane
4. Switch back to the Dom Nodes viewer

Error: getSelectedItem is not defined
Source File: chrome://inspector/content/viewers/jsObject/jsObjectViewer.js
Line: 125

It sounds like it might have been introduced with bug 588071, but quickly looking at the call stack makes it seem to me that it's a bug in the panelset/panel bindings, and we might not've been triggering it before.  I will look further into this soon.
Severity: major → normal
Summary: window-fatal error "Error: getSelectedItem is not defined" when switching from jsObject viewer to dom viewer in document pane → "Error: getSelectedItem is not defined" when switching from jsObject viewer to dom viewer in document pane
Created attachment 497213 [details] [diff] [review]
Don't call onTreeSelectionChange

The onTreeSelectionChange call is leftover from rev 506 <http://hg.mozilla.org/dom-inspector/rev/695c41c00fa5#l10.44>, when it was called onItemSelected and setting the pref triggered a rebuild.
Assignee: nobody → Sevenspade
Status: NEW → ASSIGNED
Attachment #497213 - Flags: review?(neil)

Updated

7 years ago
Attachment #497213 - Flags: review?(neil) → review+
Pushed: http://hg.mozilla.org/dom-inspector/rev/3e3eaa5504e4
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.