617063 - Change feedback xpi's labels/titles to match desktop firefox branding

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aakash Desai [:aakashd]]

The naming between mobile and desktop firefox is off and has led to some confusion by users and legal about how to properly identify if each is the same or not. Anyways, here's what I'd like to have changed:


...in install.rdf:

add-on name -> "Feedback"

...in feedback.dtd:

feedbackHeader.label -> "Feedback Tools"

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Aakash - Please verify the strings

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 501912 [details] [diff] [review]
patch

>diff --git a/app/profile/extensions/[e-mail]/install.rdf b/app/profile/extensions/[e-mail]/install.rdf
>     <em:id>[e-mail]</em:id>
>-    <em:version>1.0.0</em:version>
>+    <em:version>1.0.1</em:version>
>     <em:type>2</em:type>

Just curious, what is the common practice for updating the minor number of an embedded extension? Should we update it each time there is a change in the addon or this one is done because we want the new name to be taken into account?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #2)
> Comment on attachment 501912 [details] [diff] [review]
> patch
> 
> >diff --git a/app/profile/extensions/[e-mail]/install.rdf b/app/profile/extensions/[e-mail]/install.rdf
> >     <em:id>[e-mail]</em:id>
> >-    <em:version>1.0.0</em:version>
> >+    <em:version>1.0.1</em:version>
> >     <em:type>2</em:type>
> 
> Just curious, what is the common practice for updating the minor number of an
> embedded extension? Should we update it each time there is a change in the
> addon or this one is done because we want the new name to be taken into
> account?

No idea really. I don't have a practice myself. I just wanted bump the version somehow, since the features are being changed.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/4b97e7235e0c

Comment 5

[Aakash Desai [:aakashd]]

> Just curious, what is the common practice for updating the minor number of an
embedded extension? Should we update it each time there is a change in the
addon or this one is done because we want the new name to be taken into
account?

There isn't a common practice because this is the first time an extension is being embedded into releases. So, consider Mark the trailblazer here :).


As for the strings, looks good to me.

Comment 6

[Tony Chung [:tchung]]

will await beta 4 candidate builds to verify this

Comment 7

[Anna (Waverley)]

Can someone please verify this bug or tell me how could I access those files: install.rdf and in feedback.dtd?

Comment 8

[Cristian Nicolae (:xti)]

Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:8.0a2)Gecko/20110908
Firefox/8.0a2 Fennec/8.0a2
Device: Samsung Galaxy S
OS: Android 2.2