Closed Bug 617074 Opened 11 years ago Closed 11 years ago

Fix for building with Android 2.3 SDK (android-9 platform)

Categories

(Firefox Build System :: General, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mbrubeck, Assigned: mbrubeck)

References

Details

(Keywords: mobile, Whiteboard: [fennec-checkin-postb3])

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
The latest Android SDK changed the location of the "platform tools" directory.  This patch lets you build Fennec with the new SDK, if you add this option to your mozconfig:

--with-android-platform-tools="/path/to/android-sdk/platform-tools
Attachment #495568 - Flags: review?(khuey)
2 things:
1. I would prefer just dropping support for the old sdk entirely. However, we have to sync up with releng to update the sdk so supporting the old sdk is fine..
2. We should be able to check for a platform-tools directory and use automatically if it's there.
(In reply to comment #1)
> 2 things:
> 1. I would prefer just dropping support for the old sdk entirely. However, we
> have to sync up with releng to update the sdk so supporting the old sdk is
> fine..
> 2. We should be able to check for a platform-tools directory and use
> automatically if it's there.

We generally try to avoid adding configure options unless we absolutely have to.  I don't have any real opinion on multiple versions of the SDK.  This looks good except for that configure option.
Attached patch patch v2Splinter Review
Auto-detect the platform tools directory, rather than adding a configure option.

Also, remove the unused ANDROID_TOOLS configure variable.
Attachment #495568 - Attachment is obsolete: true
Attachment #495854 - Flags: review?(khuey)
Attachment #495568 - Flags: review?(khuey)
Comment on attachment 495854 [details] [diff] [review]
patch v2

Not sure why khuey canceled the review request; he's still welcome to chime in here if he has any opinion on the patch.  Switching review to mwu.
Attachment #495854 - Flags: review?(mwu)
Attachment #495854 - Flags: review?(mwu)
Attachment #495854 - Flags: review+
Attachment #495854 - Flags: approval2.0?
Whiteboard: [fennec-checkin-postb3]
Attachment #495854 - Flags: approval2.0? → approval2.0+
pushed http://hg.mozilla.org/mozilla-central/rev/bfb4016470c0
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Blocks: 662891
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.