617208 - The try server's first e-mail should include TryChooser options

Status: RESOLVED WONTFIX

(Release Engineering :: General, enhancement, P5)

Description

[Blake Kaplan (:mrbkap) (inactive)]

When I first push to try, I get an e-mail telling me about the new job that I just submitted. It would be really nice if the e-mail would include the options that I selected included my TryChooser options. That way, I'd be sure that I didn't typo my options (and I'd also have a record in the e-mail of what the options are).

Comment 1

[Lukas Blakk [:lsblakk] use ?needinfo]

Shouldn't be too hard to do this - I'll look into it.

Comment 2

[Justin Lebar (not reading bugmail)]

And it would be good if what it reported wasn't the "try:" string you typed, but was how TryChooser parsed that string.

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

duping bug 629425 - having the try email tell you what was parsed should also let people know in the first email if there was anything that did not lead to a build - like windows as a platform instead of the accepted win32

Comment 5

[Steve Fink [:sfink] [:s:]]

Attachment: Just include the tip comments

How about this as a stopgap solution? It doesn't report anything about the parsing, and it doesn't cover the other ways that you could set the try syntax (push comments? I don't even understand what the alternatives are.) But at least it displays the tipmost comment, which is the only way I know of to do try syntax anyway.

It makes it much easier to figure out what a try mail corresponds to.

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 673465 [details] [diff] [review]
Just include the tip comments

I'm pretty sure that this won't always work as intended since the try syntax can be in any commit of the push - try parser searches through comments until it hits "try: ".  Catlee can you confirm that?  This does look like a simple work around, but maybe we should also be doing a search for "try :" here and returning that in the initial email?

Comment 7

[Chris AtLee [:catlee]]

Comment on attachment 673465 [details] [diff] [review]
Just include the tip comments

Review of attachment 673465 [details] [diff] [review]:
-----------------------------------------------------------------

actually, I think we only look at the tip of the push these days...

Comment 8

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Found in triage.

Comment 9

[[e-mail] (:bhearsum)]

I think try chooser is dead and/or dying since the advent of "./mach try fuzzy". I'm closing this.