617267 - xpcom/io/nsWildCard.cpp(212) : warning C4244: '=' : conversion from 'const PRUnichar' to 'char', possible loss of data

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Makoto Kato [:m_kato]]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1291633325.1291641688.16997.gz&fulltext=1

e:/builds/moz2_slave/mozilla-central-win64-nightly/build/xpcom/io/nsWildCard.cpp(212) : warning C4244: '=' : conversion from 'const PRUnichar' to 'char', possible loss of data


http://mxr.mozilla.org/mozilla-central/source/xpcom/io/nsWildCard.cpp?mark=205-212#205

205 template<class T>
206 static int
207 _scan_and_copy(const T *expr, T stop1, T stop2, T *dest)
208 {
209     register int sx;     /* source index */
210     register char cc;
211 
212     for (sx = 0; (cc = expr[sx]) && cc != stop1 && cc != stop2; sx++) {

When the result of cast from PRUnichar to char is same as stop1 or stop2 even if these are different, mismatching may occur.

We should define cc as T, not char.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 2

[Joe Drew (not getting mail)]

Comment on attachment 496096 [details] [diff] [review]
fix

Sorry, it is too late for this to be landed in 2.0.

Comment 3

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/87c1707e4872