617291 - An update that changes an addon's ID will cause troubles when Firefox is closed when on the old ID's detail view was open

Status: RESOLVED INACTIVE

(Toolkit :: Add-ons Manager, defect)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Bug 412819 allowed updates to change an addon's ID. If the UI is closed while its showing that addon with its old ID, and re-opened after the ID changes, it won't find the addon. This will result in the details pane being stuck on its loading screen until you manually change views.

Comment 1

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(Note: I haven't tested this - its theoretical)

Can't rely on notifying the UI when the ID change occurs, since the UI may not be open.

The API could remember the old ID, and tell the UI when its requested.

When no addon is found in gDetailsView.show(), perhaps it should just fall back to switching to the default view, instead of just giving up and not doing anything (which results in it getting stuck showing the loading message).

Comment 2

[Dave Townsend [:mossop]]

As in bug 617289, we don't persist the details view so I don't see how this is a problem, can you actually reproduce persisting the details view somehow?

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #2)
> As in bug 617289, we don't persist the details view so I don't see how this is
> a problem, can you actually reproduce persisting the details view somehow?

Open the details view of any kind of add-on, and then close the browser. After a restart you will see the detail view selected. Could that be a session store integration issue?

Comment 4

[Dave Townsend [:mossop]]

Oh, yes, that will be session restore. I'm tempted to say that we should block that manually, either way I think this is rare enough that we shouldn't block on it.

Comment 5

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Either way, I think we need to take care of the possibility of reaching the end of gDetailsView.show() without having found an addon. At the moment it just gets stuck on the loading message - which makes it look like the UI is either broken, or still trying to load something. Pity we're past string freeze, or I'd just throw in a "Addon not found" message (that very few people will ever see).

Comment 6

[Dave Townsend [:mossop]]

Bug 618502 mitigates this, would still be nice to make it do the right thing but not a priority.

Comment 7

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.