Closed
Bug 617320
Opened 14 years ago
Closed 14 years ago
Failures in test_service_sync_updateEnabledEngines.js
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
People
(Reporter: philikon, Assigned: rnewman)
References
Details
Attachments
(1 file)
|
1.02 KB,
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
Merge was backed out due to test failures in test_service_sync_updateEnabledEngines.js: http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1291721138.1291722416.16256.gz http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1291708115.1291709734.22505.gz http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1291710025.1291711344.29001.gz http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1291709717.1291711503.29414.gz http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1291715407.1291719825.1876.gz http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1291709411.1291711437.29249.gz
|
Reporter | |
Comment 1•14 years ago
|
||
I can reproduce this failure locally on OSX after re-enabling that test.
Summary: Failures + hangs in test_service_sync_updateEnabledEngines.js → Failures in test_service_sync_updateEnabledEngines.js
|
Assignee | |
Updated•14 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•14 years ago
|
||
When we decided not to augment the test suite for the belt-and-braces engine fix, I reverted the test file... which (a) removed my test fixes, as well as the new test I was adding, and (b) removed my force-enable of the test. Of course the test suite then passed, because the tests were disabled. This patch corrects the test.
Attachment #495847 -
Flags: review?(philipp)
|
||
Comment 3•14 years ago
|
||
Comment on attachment 495847 [details] [diff] [review] Fix tests. Really... we'll have to write a crossweave test for this. File a bug on that?
Attachment #495847 -
Flags: review?(philipp) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Landed: http://hg.mozilla.org/services/fx-sync/rev/4ca4bccf59e3
|
|
Assignee | |
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•