617393 - Extend support for major release input submission methods on desktop firefox feedback addon

Status: RESOLVED FIXED

(Mozilla Labs Graveyard :: Test Pilot, defect, P1)

Description

[Aakash Desai [:aakashd]]

Attachment: mockup of differences between major rel and beta builds

Input 3.0 is going to incorporate support for major releases. Within that release, there will be 3 new submission methods and their necessary referrer information:

* Rate your experience: http://input.mozilla.com/rate (referrer: UA)
* Report a site issue: http://input.mozilla.com/brokensite (referrer: UA, URL)
* Submit ideas: http://input.mozilla.com/suggestions (referrer: UA)

The plan for these submission methods is to only be available for users on major releases. So, for beta channel users the following should happen:

* If they are on a pre-released version of firefox (betas and & rc's), they should show the happy/sad menu items. 
* If they are on a released version of firefox, they should show the rate, brokensite and submit idea menu items displayed in the mockup.

The timeline for this is before Fx4 goes out for a major release. If you have anymore questions, feel free to ask! Thanks.

Comment 1

[Aakash Desai [:aakashd]]

Oh, and the text needs to be reviewed by faaborg and limi.

Comment 2

[Fred Wenzel [:wenzel]]

(In reply to comment #0)
> * Rate your experience: http://input.mozilla.com/rate (referrer: UA)
> * Report a site issue: http://input.mozilla.com/brokensite (referrer: UA, URL)
> * Submit ideas: http://input.mozilla.com/suggestions (referrer: UA)

chowse, do these URLs work with the way you implemented the submission forms?

Comment 3

[Chris Howse [:chowse]]

My current prototype uses hashes and pushState/popState for page transitions:

http://people.mozilla.com/~chowse/drop/mozilla.com/input/3.0/proto/desktop/feedback.html
http://people.mozilla.com/~chowse/drop/mozilla.com/input/3.0/proto/desktop/feedback.html#rate
http://people.mozilla.com/~chowse/drop/mozilla.com/input/3.0/proto/desktop/feedback.html#broken
http://people.mozilla.com/~chowse/drop/mozilla.com/input/3.0/proto/desktop/feedback.html#idea

I didn't have to code for form submissions in my prototype, so you'll have to let me know if/how that'll integrate (I just assumed XHR + one last pushState).

Comment 4

[Alex Faaborg [:faaborg] (Firefox UX)]

Nothing really stood out as needing to be fixed.  I would try to avoid all capital letters though.

Question about the mockup attached: by "Any Major Release" do you mean Firefox 4?  It was my imoression that Test Pilot would only be shipped with the betas (and there wouldn't be a feedback button in primary UI).  We can of course still provide a way for users to provide feedback in the Firefox button/help menu.

Comment 5

[Aakash Desai [:aakashd]]

> Question about the mockup attached: by "Any Major Release" do you mean Firefox
> 4?  It was my imoression that Test Pilot would only be shipped with the betas
> (and there wouldn't be a feedback button in primary UI).

That's mostly true; the feedback add-on is going to continue to be packaged in beta channel builds for firefox (test pilot), so this is just a fix for that. The "submit feedback" menu item is the only consistent options for users to go to input within any build of firefox.

Of course, I could be wrong. So, a +1 or "no" from Beltzner would be nice to confirm it.

Comment 6

[Alex Faaborg [:faaborg] (Firefox UX)]

So the "any major release" mockup covers cases where users installed the feedback add-on for a non-beta build?

Comment 7

[Aakash Desai [:aakashd]]

> So the "any major release" mockup covers cases where users installed the
> feedback add-on for a non-beta build?

Users who have the feedback add-on will not have installed it. It's packaged on builds within the beta channel (only). If a user installs Test Pilot on its own, it won't turn itself into the feedback add-on.

Comment 8

[Alex Faaborg [:faaborg] (Firefox UX)]

>* If they are on a pre-released version of firefox (betas and & rc's), they
>should show the happy/sad menu items.
>The timeline for this is before Fx4 goes out for a major release.

A major release of Firefox 4 really can't have a feedback button in primary UI.  We included that button in the betas to increase the amount of feedback coming in, but it was never meant to ship with the final product.

Comment 9

[Jono Xia]

Hey guys,
I need some clarification on what, if anything, you want me to do for this one.

Current plan for Test Pilot/Feedback once the beta program ends is that we show the Feedback button UI only for users who keep the extension and remain on the beta update channel.

Given that, in what case would the three new Input menu items be shown?  Only if the version is >= 4.0 AND the user has kept the feedback add-on AND they are using the beta or nightly update channel?

Comment 10

[Aakash Desai [:aakashd]]

> Given that, in what case would the three new Input menu items be shown?  Only
> if the version is >= 4.0 AND the user has kept the feedback add-on AND they are
> using the beta or nightly update channel?

There's one other condition here: If they're on a major/minor version instead of a pre-release version (i.e. beta/rc).

The submission method links will be:

http://input.mozilla.com/feedback#rate
http://input.mozilla.com/feedback#broken
http://input.mozilla.com/feedback#idea

Shorlander has icons associated to each submission method as well.

Comment 11

[Fred Wenzel [:wenzel]]

We just agreed on changing the search for the id "id_url" to searching for all input fields with the class "url". I am going to file a bug to make this change on the Input side.

Comment 12

[Jono Xia]

I have a patch implementing this ready to go; I'm just waiting for icons and for final menu item text.

Speaking of that, the new menu items means adding new strings to main.dtd - are we allowed to do that in a patch on Firefox at this point? Aren't we string frozen or something?

Comment 13

[Alex Limi (:limi) — Firefox UX Team]

(In reply to comment #12)
> Speaking of that, the new menu items means adding new strings to main.dtd - are
> we allowed to do that in a patch on Firefox at this point? Aren't we string
> frozen or something?

Yes, we are. Add [strings] to the whiteboard, and ask for explicit approval to get any string changes in.

Comment 14

[Axel Hecht [:Pike]]

We're well past bedtime for strings, really.

If you have *really* compelling arguments to push over Johnath and I, you may get along with it *this week*.

If you don't, you're talking about busting the schedule of fx4.

Comment 15

[Aakash Desai [:aakashd]]

> If you have *really* compelling arguments to push over Johnath and I, you may
get along with it *this week*.

Yeah, I can bring it up now. I'll send an e-mail to johnath as well as yourself, Pike.

Comment 16

[Jono Xia]

Attachment: Patch implementing the reqested changes.

This patch depends on the patch in bug 604253 - that one must be applied before this one can be applied.

This patch uses the following strings for (the english versions of) the menu items:
"Rate Your Experience"
"Report A Site Issue"
"Submit Ideas"

Please let me know if these should be changed.  Also, the patch does not include the icons since I don't have them yet.  But since time is of the essence here I wanted to put it up for review ASAP.  I can redo the patch with the icons included once I get them.

A final note - the code that puts the site URL into the input fields on the web page will fill both any fields with class="url" as well as any fields with id="id_url" so that it can work both before and after the website change.

Comment 17

[Alex Faaborg [:faaborg] (Firefox UX)]

>This patch uses the following strings for (the english versions of) the menu
>items:
>"Rate Your Experience"
>"Report A Site Issue"
>"Submit Ideas"

I haven't been tracking this very closely, can you attach a screenshot?

Comment 18

[Dave Townsend [:mossop]]

Comment on attachment 503260 [details] [diff] [review]
Patch implementing the reqested changes.

r+ pending the decision on whether we can take hte strings at this point.

Comment 19

[Aakash Desai [:aakashd]]

The strings are final now

Comment 20

[Dave Townsend [:mossop]]

(In reply to comment #19)
> The strings are final now

Does that mean johnath and axel have approved these string changes to land?

Comment 21

[Mike Beltzner [:beltzner, not reading bugmail]]

Or that the strings have gone through a ui-review request?

Comment 22

[Johnathan Nightingale [:johnath]]

Comment on attachment 503260 [details] [diff] [review]
Patch implementing the reqested changes.

I should have commented here sooner, sorry about that. I'm on point for managing strings landing and all, but actual approval of the string content themselves is a ui-review call. Tagging beltzner, though he may well defer. We should get it wrapped post-haste though, I agree.

Comment 23

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 503260 [details] [diff] [review]
Patch implementing the reqested changes.

>+<!ENTITY testpilot.rate.label        "Rate Your Experience">

I'd suggest removing this entirely, because it's more of a one-time survey, and I can't see people coming back to it repeatedly. The main intent of the "Rate Your Experience" function on Input is to capture the release audience's impressions, and I don't think Beta users will keep re-submitting the survey.

>+<!ENTITY testpilot.broken.label          "Report A Site Issue">

I think "Report this website as broken..." works better

>+<!ENTITY testpilot.idea.label        "Submit Ideas">

Here, perhaps "Give us a suggestion..." instead.

uir+ with those nits

Comment 24

[Aakash Desai [:aakashd]]

wfm!

Comment 25

[Jono Xia]

Attachment: Revised version of patch, incorporating Beltzner's requests

This version of the patch implements Beltzner's requested string changes.  The 'rate your experience' option was removed completely and the other two items had their names changed.

This patch does not include icons.  Once Shorlander finishes them I will incorporate them into one final version of the patch.

Comment 26

[Jono Xia]

Attachment: Final version of patch, including icons

This patch is as the previous version, but it also includes Shorlander's icons.  That should make it the the final version of the patch.

Comment 27

[Dave Townsend [:mossop]]

Landed: http://hg.mozilla.org/mozilla-central/rev/cd52999e29c7