617437 - Sync randomly moved dozens of bookmarks out of folders into the Unsorted Bookmarks folder

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Steffen Wilberg]

Mozilla/5.0 (Windows NT 6.1; rv:2.0b8pre) Gecko/20101207 Firefox/4.0b8pre

I have my bookmarks sorted into folders and sub-folders below the Bookmarks Menu "folder".

Today, Sync randomly moved dozens of bookmarks out of folders into the Unsorted Bookmarks folder. Some folders were not affected, but others were completely emptied, leaving empty folders behind, others were only partly raided.

From the log:
2010-12-07 19:13:44	Service.Main         DEBUG	Weave Version: @weave_version@ Local Storage: 4 Remote Storage: 4

2010-12-07 19:13:45	Engine.Bookmarks     DEBUG	First sync, uploading all items
2010-12-07 19:13:46	Engine.Bookmarks     INFO	534 outgoing items pre-reconciliation

2010-12-07 19:13:55	Engine.Bookmarks     WARN	Error processing record: Component returned failure code: 0x80004001 (NS_ERROR_NOT_IMPLEMENTED) [nsIAnnotationService.setItemAnnotation] Stack trace: anno()@resource://services-sync/util.js:270 < resource://services-sync/engines/bookmarks.js:677 < BStore_changeItemID()@resource://services-sync/engines/bookmarks.js:678 < _handleDupe()@resource://services-sync/engines/bookmarks.js:248 < resource://services-sync/engines.js:201 < SyncEngine__reconcile()@resource://services-sync/engines.js:628 < resource://services-sync/engines.js:201 < resource://services-sync/engines.js:466 < innerBind()@resource://services-sync/util.js:1336 < resource://services-sync/base_records/collection.js:154 < Channel_onDataAvail()@resource://services-sync/resource.js:451
(22 times)

2010-12-07 19:13:59	Store.Bookmarks      DEBUG	Reparenting orphans 950,494,1295,1296 to 492
(12 times)

2010-12-07 19:27:54	Service.Main         INFO	Sync completed successfully in 850.79 secs.

Comment 1

[Steffen Wilberg]

Attachment: sync log, part 1

There were also more than 200 entries like this:
2010-12-07 19:13:49	Store.Bookmarks      DEBUG	Changing GUID akSNP9vHK3xJ to -2thGvJjaexG

Comment 2

[Steffen Wilberg]

Attachment: sync log, part 2

Comment 3

[Philipp von Weitershausen [:philikon]]

(In reply to comment #1)
> There were also more than 200 entries like this:
> 2010-12-07 19:13:49    Store.Bookmarks      DEBUG    Changing GUID akSNP9vHK3xJ
> to -2thGvJjaexG

That's expected as the bookmarks engine consolidates duplicates. The exception you're seeing isn't.

Comment 4

[Philipp von Weitershausen [:philikon]]

Ok, I've taken a closer look at this. First of all, Steffen, sorry we broke your bookmarks :/ Good news is that Sync makes backups of your bookmarks before syncing. You can restore by going to Bookmarks -> Show All Bookmarks and then clicking on the star icon in the window that opens.

Now for the actual problem: I can see some oddities with dupes, in other words, when two machines have the same set of bookmarks and Sync needs to reconcile. I have identified some problematic areas in the code and am addressing them.

I cannot reproduce the exception at all, though. Are you seeing oddities with a particular group of bookmarks or folders? If you want feel free to send me your bookmark backup file (the .json file the bookmark backup saves) via private email so I stand a better chance of reproducing. Though if you'd rather not that's ok.

Comment 5

[Mike Connor [:mconnor]]

This should be fixed now.

Comment 6

[Tracy Walker [:tracy]]

reporter, please verify this is fixed for you.

Comment 7

[Steffen Wilberg]

This didn't happen again, and I can't reproduce it because I failed to make a backup of the bookmarks backup file after it happened, so that backup is gone :(

Comment 8

[Tracy Walker [:tracy]]

Ok, thank you, Steffen.

Comment 9

[marty]

I am still having this problem. I've had hundreds of carefully organized business bookmarks scrambled during desktop PC syncs with my laptop pc, android phone, and ipad. It happens every time I add a new device.

Comment 10

[marty]

See bug #812348

Comment 11

[Richard Newman [:rnewman]]

This is a very old bug, addressing particular issues; let's keep your discussion in Bug 812348, marty.

Thanks!