Closed Bug 617478 Opened 10 years ago Closed 10 years ago

Service.startOver() needs to clear all memoization from CollectionKeys

Categories

(Firefox :: Sync, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- beta8+

People

(Reporter: philikon, Assigned: rnewman)

References

Details

Attachments

(1 file)

1. Have Firefox connected to account A, sync successfully etc.
2. Now connect Firefox to account B, sync.
3. Observe HMAC failures in about:sync-log.

It looks like the old keys from account A still stuck around. So somehow the
Sync Key validation in the setup wizard (which calls verifyLogin/login)
succeeded but subsequently it still kept the old keys around.

We used to dump the local key cache in Weave.Service.startOver(), but it
doesn't look like we're doing this to the CollectionKeys cache.
blocking2.0: --- → ?
tracking-fennec: --- → ?
blocking2.0: ? → beta8+
Philipp, could you please verify that this fixes your reported issue?

Tests pass...
Attachment #496010 - Flags: review?(philipp)
Comment on attachment 496010 [details] [diff] [review]
Add a clear() method and use it.

Yep, that fixes things nicely. Code and test look good, too.
Attachment #496010 - Flags: review?(philipp) → review+
Thanks Philipp. Pushed:

http://hg.mozilla.org/services/fx-sync/rev/a9b13f2ae3f2
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Blocks: 617271
tracking-fennec: ? → ---
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.