617478 - Service.startOver() needs to clear all memoization from CollectionKeys

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Philipp von Weitershausen [:philikon]]

1. Have Firefox connected to account A, sync successfully etc.
2. Now connect Firefox to account B, sync.
3. Observe HMAC failures in about:sync-log.

It looks like the old keys from account A still stuck around. So somehow the
Sync Key validation in the setup wizard (which calls verifyLogin/login)
succeeded but subsequently it still kept the old keys around.

We used to dump the local key cache in Weave.Service.startOver(), but it
doesn't look like we're doing this to the CollectionKeys cache.

Comment 1

[Richard Newman [:rnewman]]

Attachment: Add a clear() method and use it.

Philipp, could you please verify that this fixes your reported issue?

Tests pass...

Comment 2

[Philipp von Weitershausen [:philikon]]

Comment on attachment 496010 [details] [diff] [review]
Add a clear() method and use it.

Yep, that fixes things nicely. Code and test look good, too.

Comment 3

[Richard Newman [:rnewman]]

Thanks Philipp. Pushed:

http://hg.mozilla.org/services/fx-sync/rev/a9b13f2ae3f2