Closed
Bug 617499
Opened 14 years ago
Closed 14 years ago
Add an e10s test to verify behavior of async messages sent by Firefox while the addon process is making a synchronous call
Categories
(Add-on SDK Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: avarma, Assigned: avarma)
Details
Attachments
(1 file)
bsmedberg said that the addon process doesn't do any kind of message queuing, so an async message sent while Firefox is responding to a synchronous call from the addon process should actually be received and acted upon in the addon process before its synchronous call completes. We should verify this though, both so that we know the situation doesn't change, and so that someone reading the test suite has a better idea of what e10s' behavior is.
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → avarma
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•14 years ago
|
||
Assignee | ||
Updated•14 years ago
|
Attachment #496201 -
Flags: review?(myk)
Comment 2•14 years ago
|
||
Comment on attachment 496201 [details] Pointer to pull request (In reply to comment #0) > bsmedberg said that the addon process doesn't do any kind of message queuing, > so an async message sent while Firefox is responding to a synchronous call from > the addon process should actually be received and acted upon in the addon > process before its synchronous call completes. Is it actually true that it should be received, or is it merely the case that it may be received? It's unclear to me whether an asynchronous message sent from the chrome process must necessarily be received by the content process before the blocking call from addon to chrome returns, so I'm worried about a race condition in this test. Nevertheless, it seems to work, so r=myk for now.
Attachment #496201 -
Flags: review?(myk) → review+
Comment 3•14 years ago
|
||
Fix commit: https://github.com/mozilla/addon-sdk/commit/985418ddd8bfd21a22b57609c628461569d14274 Merge commit: https://github.com/mozilla/addon-sdk/commit/6822f0d7853200cf21e6430701c103a1dfa4b529
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•