617634 - SVGPathData::GetMarkerPositioningData checks for PATHSEG_CURVETO_QUADRATIC_ABS instead of PATHSEG_CURVETO_QUADRATIC_SMOOTH_ABS

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[timeless]

452 SVGPathData::GetMarkerPositioningData(nsTArray<nsSVGMark> *aMarks) const
453 {
...
462   PRUint16 segType, prevSegType = nsIDOMSVGPathSeg::PATHSEG_UNKNOWN;
...
471   while (i < mData.Length()) {
472     segType = SVGPathSegUtils::DecodeType(mData[i++]); // advances i to args
474     switch (segType) // to find segStartAngle, segEnd and segEndAngle
475     {
...
666     case nsIDOMSVGPathSeg::PATHSEG_CURVETO_CUBIC_SMOOTH_ABS:
667     case nsIDOMSVGPathSeg::PATHSEG_CURVETO_CUBIC_SMOOTH_REL:
668       cp1 = SVGPathSegUtils::IsCubicType(prevSegType) ? segStart * 2 - prevCP : segStart;
669       if (segType == nsIDOMSVGPathSeg::PATHSEG_CURVETO_CUBIC_SMOOTH_ABS) {
...
686       break;
687 
688     case nsIDOMSVGPathSeg::PATHSEG_CURVETO_QUADRATIC_SMOOTH_ABS:
689     case nsIDOMSVGPathSeg::PATHSEG_CURVETO_QUADRATIC_SMOOTH_REL:
690       cp1 = SVGPathSegUtils::IsQuadraticType(prevSegType) ? segStart * 2 - prevCP : segStart;
this if statement can't be reached, it looks like a copy and paste error from the 
691       if (segType == nsIDOMSVGPathSeg::PATHSEG_CURVETO_QUADRATIC_ABS) {

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Jonathan Watt [:jwatt]]

http://hg.mozilla.org/mozilla-central/rev/9b7157931d79